<p>Joshua C. Colp <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/11137">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Sean Bright: Looks good to me, but someone else must approve
Joshua C. Colp: Looks good to me, approved; Approved for Submit
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Makefile.moddir_rules: Pass PJPROJECT_BUNDLED to download_externals<br><br>The download_externals script wasn't getting the PJPROJECT_BUNDLED<br>environment variable passed down to it so it wasn't downloading<br>the appropriate variant of res_digium_phone. This could cause<br>crashes in the DPMA.<br><br>Change-Id: I5daa9369c7af1fd556d892e89a85f279a2533425<br>---<br>M Makefile.moddir_rules<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Makefile.moddir_rules b/Makefile.moddir_rules</span><br><span>index c9f94f9..795b32c 100644</span><br><span>--- a/Makefile.moddir_rules</span><br><span>+++ b/Makefile.moddir_rules</span><br><span>@@ -114,7 +114,7 @@</span><br><span> EXTERNAL_MODS=$$($(XMLSTARLET) sel -t -m "/category/member[support_level = 'external']" -v "@name" -n .moduleinfo) ;\</span><br><span> for x in $${EXTERNAL_MODS} ; do \</span><br><span> if [ -z "$${DISABLED_MODS[$${x}]}" ] ; then \</span><br><span style="color: hsl(0, 100%, 40%);">- $(ASTTOPDIR)/build_tools/download_externals $${x} ;\</span><br><span style="color: hsl(120, 100%, 40%);">+ PJPROJECT_BUNDLED=${PJPROJECT_BUNDLED} $(ASTTOPDIR)/build_tools/download_externals $${x} ;\</span><br><span> fi ;\</span><br><span> done ;\</span><br><span> fi</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11137">change 11137</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11137"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5daa9369c7af1fd556d892e89a85f279a2533425 </div>
<div style="display:none"> Gerrit-Change-Number: 11137 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua C. Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>