<p style="white-space: pre-wrap; word-wrap: break-word;">Hi Joshua,</p><p style="white-space: pre-wrap; word-wrap: break-word;">Thank you for your kind reviewing. I've fixed it. :)</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/11083">View Change</a></p><p>9 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/11083/5//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11083/5//COMMIT_MSG@9">Patch Set #5, Line 9:</a> <code style="font-family:monospace,monospace">Added ARI resource for channel statisctics.</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">statistics</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ooops!</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11083/5//COMMIT_MSG@10">Patch Set #5, Line 10:</a> <code style="font-family:monospace,monospace">GET /ari/channels/{channelId}/stats : It returns given</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I don't think this is the right name for this. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Agree. I've fixed it. :)</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/11083/5/channels/chan_pjsip.c">File channels/chan_pjsip.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11083/5/channels/chan_pjsip.c@1275">Patch Set #5, Line 1275:</a> <code style="font-family:monospace,monospace"> j_res = ast_json_array_create();</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I don't think it should be the responsibility of the channel driver to construct this information. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Agree, I've just didn't know about the 'glue'. Now, I've removed all the channel driver stuffs. :)</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/11083/5/include/asterisk/channel.h">File include/asterisk/channel.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11083/5/include/asterisk/channel.h@829">Patch Set #5, Line 829:</a> <code style="font-family:monospace,monospace"> struct ast_json * (* get_rtp_stats)(struct ast_channel *chan, const int type);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I don't think this is necessary. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Thanks, that was what I wanted. :) Removed all the channel driver stuffs. :)</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/11083/5/main/rtp_engine.c">File main/rtp_engine.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11083/5/main/rtp_engine.c@3748">Patch Set #5, Line 3748:</a> <code style="font-family:monospace,monospace"> j_res = ast_json_object_create();</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This can fail.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Agree, fixed it to set the value when it was succeed.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11083/5/main/rtp_engine.c@3750">Patch Set #5, Line 3750:</a> <code style="font-family:monospace,monospace"> ast_json_object_set(j_res, "txcount", ast_json_integer_create(stats->txcount));</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">All of these various calls can also fail, leaving the resulting object in an undefined incomplete st […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same live above. :)</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/11083/5/res/ari/resource_channels.c">File res/ari/resource_channels.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11083/5/res/ari/resource_channels.c@1966">Patch Set #5, Line 1966:</a> <code style="font-family:monospace,monospace"></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">If the underlying channel is not RTP should this return a different response code?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Agree, fixed to 403 when the channel is not suitable tech type, and added more 404 response cases.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/11083/5/rest-api/api-docs/channels.json">File rest-api/api-docs/channels.json:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11083/5/rest-api/api-docs/channels.json@1677">Patch Set #5, Line 1677:</a> <code style="font-family:monospace,monospace"> "path": "/channels/{channelId}/stats",</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Per my commit message comment - I don't think this is the right name for this</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Agree, fixed it. :)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11083/5/rest-api/api-docs/channels.json@1678">Patch Set #5, Line 1678:</a> <code style="font-family:monospace,monospace"> "description": "RTP stats on a channel",</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I think this description could be better: […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Yes, your description is better. Fixed it. :)</p><p style="white-space: pre-wrap; word-wrap: break-word;">But, changed the RTCP to RTP. </p><p style="white-space: pre-wrap; word-wrap: break-word;">Get RTP statistics information for RTP on a channel</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11083">change 11083</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11083"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4343eec070438cec13f2a4f22e7fd9e574381376 </div>
<div style="display:none"> Gerrit-Change-Number: 11083 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: sungtae kim <pchero21@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: sungtae kim <pchero21@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 06 Mar 2019 00:22:32 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>