<p>Friendly Automation <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/11091">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Joshua Colp: Looks good to me, but someone else must approve
Benjamin Keith Ford: Looks good to me, but someone else must approve
George Joseph: Looks good to me, approved
Friendly Automation: Approved for Submit
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sip_to_pjsip: Make multiline comment parsing consistent with Asterisk<br><br>In Asterisk configuration, a multiline comment starts with ;-- as long as it is<br>not followed by another dash (i.e. ;--- is not a multiline comment).<br><br>ASTERISK-28323 #close<br><br>Change-Id: I32dc38e0fac01d3c0805d27d35d2365a7c37ca72<br>---<br>M contrib/scripts/sip_to_pjsip/astconfigparser.py<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/contrib/scripts/sip_to_pjsip/astconfigparser.py b/contrib/scripts/sip_to_pjsip/astconfigparser.py</span><br><span>index 949acdb..ee857e2 100644</span><br><span>--- a/contrib/scripts/sip_to_pjsip/astconfigparser.py</span><br><span>+++ b/contrib/scripts/sip_to_pjsip/astconfigparser.py</span><br><span>@@ -180,7 +180,7 @@</span><br><span> return "", True</span><br><span> </span><br><span> part = line.partition(COMMENT_START)</span><br><span style="color: hsl(0, 100%, 40%);">- if part[1]:</span><br><span style="color: hsl(120, 100%, 40%);">+ if part[1] and not part[2].startswith('-'):</span><br><span> # found multi-line comment start check string before</span><br><span> # it to make sure there wasn't an eol comment in it</span><br><span> has_comment = part[0].partition(COMMENT)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11091">change 11091</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11091"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: I32dc38e0fac01d3c0805d27d35d2365a7c37ca72 </div>
<div style="display:none"> Gerrit-Change-Number: 11091 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>