<p><a href="https://gerrit.asterisk.org/10800">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10800/1/CHANGES">File CHANGES:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10800/1/CHANGES@18">Patch Set #1, Line 18:</a> <code style="font-family:monospace,monospace">   which will allow you to create aliases for physical mailboxes. </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Red space, just ignore if other comment doesn't require action :)</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10800/1/apps/app_voicemail.c">File apps/app_voicemail.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10800/1/apps/app_voicemail.c@1804">Patch Set #1, Line 1804:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">          mapping = ao2_find(alias_mailbox_mappings, search_string, OBJ_SEARCH_KEY);<br>            if (mapping) {<br>                        char *search_mailbox;<br>                 char *search_context;<br><br>                       separate_mailbox(ast_strdupa(mapping->mailbox), &search_mailbox, &search_context);<br>                 vmu = find_user(ivm, search_mailbox, search_context);<br>         }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should there be an ao2_ref call here? Just curious since it would follow the pattern of the other calls like this.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10800/1/apps/app_voicemail.c@8157">Patch Set #1, Line 8157:</a> <code style="font-family:monospace,monospace">            ast_publish_mwi_state_channel(mailbox, context, new + urgent, old, channel_id);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Would this potentially post a state update twice (or more than twice) for a mailbox, specifically ones that can be found but also have aliases for them?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10800">change 10800</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10800"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I395b9205c91523a334fe971be0d1de4522067b04 </div>
<div style="display:none"> Gerrit-Change-Number: 10800 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation (1000185) </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 13 Dec 2018 17:48:06 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>