<p><a href="https://gerrit.asterisk.org/10621">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10621/1/main/taskprocessor.c">File main/taskprocessor.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10621/1/main/taskprocessor.c@520">Patch Set #1, Line 520:</a> <code style="font-family:monospace,monospace"> maxqsize = tps->stats.max_qsize;</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Was it ever possible in the first place to not have tps->stats?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">No. __allocate_taskprocessor unconditionally allocated tps->stats and failed the whole thing if that calloc failed. See the check at line 761 of the original source.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10621/1/main/taskprocessor.c@752">Patch Set #1, Line 752:</a> <code style="font-family:monospace,monospace"> ao2_ref(listener, +1);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">As you're in the area why not roll this into the ao2_alloc and eliminate this memory allocation?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">That seems reasonable for 13/16 but I have plans for master to use a weakproxy in tps_singletons, that weakproxy will own the storage for name.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10621">change 10621</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10621"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I74fe9a7f357f0e6d63152f163cf5eef6428218e1 </div>
<div style="display:none"> Gerrit-Change-Number: 10621 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 12 Nov 2018 13:15:37 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>