<p><a href="https://gerrit.asterisk.org/10577">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10577/3/channels/pjsip/dialplan_functions.c">File channels/pjsip/dialplan_functions.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10577/3/channels/pjsip/dialplan_functions.c@1068">Patch Set #3, Line 1068:</a> <code style="font-family:monospace,monospace">     pool = pjsip_endpt_create_pool(ast_sip_get_pjsip_endpoint(), "ParseUri", 128, 128);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This is violating the PJSIP/Asterisk boundary. […]</blockquote></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">I don't understand.<br>I see a lot of pjsip_endpt_create_pool/pjsip_endpt_release_pool<br>without dispatching into the PJSIP thread to execute.<br>For example.<br>=== inside function channel_read_pjsip ===<br>                pj_pool_t *pool = pjsip_endpt_create_pool(ast_sip_get_pjsip_endpoint(), "secure-check", 128, 128);<br>                pjsip_get_dest_info(dlg->target, NULL, pool, &dest);<br>                snprintf(buf, buflen, "%d", dest.flag & PJSIP_TRANSPORT_SECURE ? 1 : 0);<br>                pjsip_endpt_release_pool(ast_sip_get_pjsip_endpoint(), pool);<br>======<br>=== inside function sip_outbound_registration_regc_alloc ===<br>        pool = pjsip_endpt_create_pool(ast_sip_get_pjsip_endpoint(), "URI Validation", 256, 256);<br>...<br>        pjsip_endpt_release_pool(ast_sip_get_pjsip_endpoint(), pool);</pre><p style="white-space: pre-wrap; word-wrap: break-word;">======</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10577">change 10577</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10577"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I5d828fb87f6803b6c1152bb7b44835f027bb9d5a </div>
<div style="display:none"> Gerrit-Change-Number: 10577 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 05 Nov 2018 17:11:37 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>