<p style="white-space: pre-wrap; word-wrap: break-word;">Since this is a new feature, testsuite tests are required for the patch to be accepted in released branches. Otherwise, it can only go into the master branch.</p><p style="white-space: pre-wrap; word-wrap: break-word;">https://wiki.asterisk.org/wiki/display/AST/New+Feature+Guidelines</p><p><a href="https://gerrit.asterisk.org/10480">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10480/1/include/asterisk/res_pjsip.h">File include/asterisk/res_pjsip.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10480/1/include/asterisk/res_pjsip.h@563">Patch Set #1, Line 563:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> /*! Do we accept connected line updates from this endpoint? */<br> unsigned int trust_connected_line;<br> /*! Do we send connected line updates to this endpoint? */<br> unsigned int send_connected_line;<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This is the correct spot for the master version only. However, for released versions, adding these parameters here breaks ABI compatibility. For released versions, these must go at the end of the struct ast_sip_endpoint.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10480/1/res/res_pjsip.c">File res/res_pjsip.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10480/1/res/res_pjsip.c@192">Patch Set #1, Line 192:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> <configOption name="trust_connected_line" default="yes"><br> <synopsis>Accept Connected Line updates from this endpoint</synopsis><br> </configOption><br> <configOption name="send_connected_line" default="yes"><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">It is best to not specify a default here. Specifying the default here is ignored and can get out of sync with where it is actually effective. The default specified with ast_sorcery_object_field_register() is used.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10480/1/res/res_pjsip/pjsip_configuration.c">File res/res_pjsip/pjsip_configuration.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10480/1/res/res_pjsip/pjsip_configuration.c@1772">Patch Set #1, Line 1772:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> ast_sorcery_object_field_register(sip_sorcery, "endpoint", "trust_connected_line", "yes", OPT_BOOL_T, 1, FLDSET(struct ast_sip_endpoint, id.trust_connected_line));<br> ast_sorcery_object_field_register(sip_sorcery, "endpoint", "send_connected_line", "yes", OPT_BOOL_T, 1, FLDSET(struct ast_sip_endpoint, id.send_connected_line));<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Since you are using yes/no for the strings you need to use OPT_YESNO_T instead of OPT_BOOL_T. The only difference between the two is that OPT_YESNO_T writes configuration output using yes/no strings rather than true/false strings.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10480/1/res/res_pjsip_caller_id.c">File res/res_pjsip_caller_id.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10480/1/res/res_pjsip_caller_id.c@345">Patch Set #1, Line 345:</a> <code style="font-family:monospace,monospace"> if (!session->endpoint->id.trust_connected_line || !session->endpoint->id.trust_inbound) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">guidelines: Long lines need to be wrapped when over 90 columns.</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><br>if (!session->endpoint->id.trust_connected_line<br> || !session->endpoint->id.trust_inbound) {<br>}</pre></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10480/1/res/res_pjsip_caller_id.c@753">Patch Set #1, Line 753:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> if (!session->channel<br> || (!session->endpoint->id.send_connected_line<br> && session->inv_session && session->inv_session->state >= PJSIP_INV_STATE_EARLY)) {<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">guidelines: wrap long line</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">if (!session->channel<br> || (!session->endpoint->id.send_connected_line<br> && session->inv_session<br> && session->inv_session->state >= PJSIP_INV_STATE_EARLY)) {<br>}</pre></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10480">change 10480</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10480"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I16af967815efd904597ec2f033337e4333d097cd </div>
<div style="display:none"> Gerrit-Change-Number: 10480 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 16 Oct 2018 20:55:25 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>