<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/10270">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10270/1/res/res_pjsip/location.c">File res/res_pjsip/location.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10270/1/res/res_pjsip/location.c@a1021">Patch Set #1, Line 1021:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This function appears to no longer be used, so can be removed as well. Same for the "cli_contact_populate_container" callback.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10270/1/res/res_pjsip/location.c@1027">Patch Set #1, Line 1027:</a> <code style="font-family:monospace,monospace">         ast_free(wrapper->contact_id);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This should be removed. The contact_id's memory is free'd in the wrapper's destructor.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10270/1/res/res_pjsip/location.c@1031">Patch Set #1, Line 1031:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">       wrapper->contact = contact;<br>        ao2_bump(wrapper->contact);<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This can be combined into a single statement if you want:</p><p style="white-space: pre-wrap; word-wrap: break-word;">wrapper->contact = ao2_bump(contact)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10270/1/res/res_pjsip/location.c@1036">Patch Set #1, Line 1036:</a> <code style="font-family:monospace,monospace">        return 0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Use tabs here instead of spaces for indention.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10270">change 10270</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10270"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id0ad65d14952a02fb213273a90f3f680a8149618 </div>
<div style="display:none"> Gerrit-Change-Number: 10270 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 27 Sep 2018 16:45:29 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>