<p>George Joseph has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/10024">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">stasis_cache: Don't cache stasis_subscription_change messages<br><br>stasis_subscription_change messages can provide useful information<br>to topic subscribers but caching them makes no sense since they<br>don't alter the state of the object the topic is related to.<br>They do however take CPU cycles to manage in the cache and consume<br>memory in the cache container.<br><br>Change-Id: I3d18905e477f3721815da91f30da8d3fbb2d4f56<br>---<br>M main/stasis_cache.c<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/24/10024/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/main/stasis_cache.c b/main/stasis_cache.c</span><br><span>index 8c3c7f1..752bb8c 100644</span><br><span>--- a/main/stasis_cache.c</span><br><span>+++ b/main/stasis_cache.c</span><br><span>@@ -813,7 +813,9 @@</span><br><span>      }</span><br><span> </span><br><span>        msg_type = stasis_message_type(message);</span><br><span style="color: hsl(0, 100%, 40%);">-        if (stasis_cache_clear_type() == msg_type) {</span><br><span style="color: hsl(120, 100%, 40%);">+  if (stasis_subscription_change_type() == msg_type) {</span><br><span style="color: hsl(120, 100%, 40%);">+          return;</span><br><span style="color: hsl(120, 100%, 40%);">+       } else if (stasis_cache_clear_type() == msg_type) {</span><br><span>          /* Cache clear event. */</span><br><span>             msg_put = NULL;</span><br><span>              msg = stasis_message_data(message);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/10024">change 10024</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10024"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I3d18905e477f3721815da91f30da8d3fbb2d4f56 </div>
<div style="display:none"> Gerrit-Change-Number: 10024 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>