<p>George Joseph <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/10008">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Richard Mudgett: Looks good to me, but someone else must approve
George Joseph: Looks good to me, approved; Approved for Submit
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">res/res_rtp_asterisk: remove debug traces generated by an empty frame<br><br>The realtime text timer pops regularly and sends text frames even if<br>the buffer is empty. This causes a lot of unecessary debug logging.<br><br>* Made red_write() test if we need to send a frame before calling<br>ast_rtp_write()<br><br>ASTERISK-28002<br>Reported by: Emmanuel BUU<br>Tested by: Emmanuel BUU<br><br>Change-Id: Icf81310c3b8080b615a42060afc02ab41f9523dd<br>---<br>M res/res_rtp_asterisk.c<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/res/res_rtp_asterisk.c b/res/res_rtp_asterisk.c</span><br><span>index fa9e325..c1aa275 100644</span><br><span>--- a/res/res_rtp_asterisk.c</span><br><span>+++ b/res/res_rtp_asterisk.c</span><br><span>@@ -7382,7 +7382,9 @@</span><br><span> struct ast_rtp *rtp = ast_rtp_instance_get_data(instance);</span><br><span> </span><br><span> ao2_lock(instance);</span><br><span style="color: hsl(0, 100%, 40%);">- ast_rtp_write(instance, &rtp->red->t140);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rtp->red->t140.datalen > 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ast_rtp_write(instance, &rtp->red->t140);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> ao2_unlock(instance);</span><br><span> </span><br><span> return 1;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/10008">change 10008</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10008"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Icf81310c3b8080b615a42060afc02ab41f9523dd </div>
<div style="display:none"> Gerrit-Change-Number: 10008 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Emmanuel BUU <emmanuel.buu@ives.fr> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>