<p><a href="https://gerrit.asterisk.org/10006">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10006/2/configure">File configure:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10006/2/configure@8921">Patch Set #2, Line 8921:</a> <code style="font-family:monospace,monospace">PBX_NO_BINARY_MODULES=0</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">> Are you wanting me to have a default value PBX_BINARY_MODULES=1 and […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This is the generated file, does your comment apply to configure.ac? The `enable_binary_modules` variable and comment about --enable-binary-modules is calculated by AC_ARG_ENABLE and there is no AC_ARG_DISABLE. With this regard I'm not seeing the difference from --disable-xmldoc which also uses ${enable_xmldoc} and has a comment about checking for --enable-xmldoc.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10006">change 10006</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10006"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I6b1bd1c75a2e48f05b8b8a45b7a7a2d00a079166 </div>
<div style="display:none"> Gerrit-Change-Number: 10006 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 28 Aug 2018 15:07:34 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>