<p>George Joseph <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/9990">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Joshua Colp: Looks good to me, but someone else must approve
Richard Mudgett: Looks good to me, approved
George Joseph: Approved for Submit
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">chan_sip: remove unnecessary ast_channel_unlock(peer) as RAII looks after it<br><br>Otherwise console output<br><br> (get_refer_info): mutex 'peer' freed more times than we've locked!<br> (get_refer_info): Error releasing mutex: Operation not permitted<br><br> or<br> (get_refer_info): attempted unlock mutex 'peer' without owning it!<br> (__ast_read): 'peer' was locked here.<br> ...dump_backtrace<br><br> (get_refer_info): Error releasing mutex: Operation not permitted<br> (__ast_read): mutex 'chan' freed more times than we've locked!<br><br>ASTERISK-28011 #close<br><br>Change-Id: I6e45f2764ba4f3273a943300f91ac9b461ac2893<br>---<br>M channels/chan_sip.c<br>1 file changed, 0 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/channels/chan_sip.c b/channels/chan_sip.c</span><br><span>index ad06422..de61343 100644</span><br><span>--- a/channels/chan_sip.c</span><br><span>+++ b/channels/chan_sip.c</span><br><span>@@ -18740,7 +18740,6 @@</span><br><span> S_OR(transferer->context, NULL));</span><br><span> pbx_builtin_setvar_helper(peer, "__SIPREFERREDBYHDR",</span><br><span> S_OR(p_referred_by, NULL));</span><br><span style="color: hsl(0, 100%, 40%);">- ast_channel_unlock(peer);</span><br><span> }</span><br><span> </span><br><span> owner_relock = sip_pvt_lock_full(transferer);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/9990">change 9990</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9990"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I6e45f2764ba4f3273a943300f91ac9b461ac2893 </div>
<div style="display:none"> Gerrit-Change-Number: 9990 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Alec Davis <sivad.a@paradise.net.nz> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Matthew Fredrickson <creslin@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>