<p>Joshua Colp <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/9854">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Richard Mudgett: Looks good to me, but someone else must approve
Jaco Kroon: Looks good to me, but someone else must approve
Joshua Colp: Looks good to me, approved; Approved for Submit
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">app_queue: set QUEUESTATUS to LEAVEEMPTY instead of CONTINUE<br><br>When a call leaves a queue on leaveempty condition, QUEUESTATUS<br>must be set to LEAVEEMPTY, no matter whether Queue was executed with or<br>without the "c" (continue) option.<br><br>The regression was introduced in the fix for ASTERISK_25665.<br>The following fix (ASTERISK_27065) was incomplete, as QUEUESTATUS was<br>overwritten in case when "c" is set, regardless of what was the cause<br>for leaving the queue.<br><br>ASTERISK-27973 #close<br>Reported-by: Valentin Safonov<br><br>Change-Id: Iec013fe6a26a4e825ca572a1dda4f3cee5f6f80c<br>---<br>M apps/app_queue.c<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/apps/app_queue.c b/apps/app_queue.c</span><br><span>index f783ac9..31580b4 100644</span><br><span>--- a/apps/app_queue.c</span><br><span>+++ b/apps/app_queue.c</span><br><span>@@ -8172,12 +8172,12 @@</span><br><span> "%d|%d|%ld", qe.pos, qe.opos,</span><br><span> (long) (time(NULL) - qe.start));</span><br><span> res = -1;</span><br><span style="color: hsl(0, 100%, 40%);">- } else if (qcontinue) {</span><br><span style="color: hsl(0, 100%, 40%);">- reason = QUEUE_CONTINUE;</span><br><span style="color: hsl(0, 100%, 40%);">- res = 0;</span><br><span> } else if (reason == QUEUE_LEAVEEMPTY) {</span><br><span> /* Return back to dialplan, don't hang up */</span><br><span> res = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ } else if (qcontinue) {</span><br><span style="color: hsl(120, 100%, 40%);">+ reason = QUEUE_CONTINUE;</span><br><span style="color: hsl(120, 100%, 40%);">+ res = 0;</span><br><span> }</span><br><span> } else if (qe.valid_digits) {</span><br><span> ast_queue_log(args.queuename, ast_channel_uniqueid(chan), "NONE", "EXITWITHKEY",</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/9854">change 9854</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9854"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Iec013fe6a26a4e825ca572a1dda4f3cee5f6f80c </div>
<div style="display:none"> Gerrit-Change-Number: 9854 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Ivan Poddubny <ivan.poddubny@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jaco Kroon <jaco@uls.co.za> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>