<p>George Joseph has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/9644">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pjsip/transfer: Remove obsolete sipp options<br><br>Some of the blind transfer hold tests were using -min_rtp_port and<br>-max_rtp_port sipp options. These are now obsolete and cause sipp<br>to comaplin and the tests to fail.<br><br>Removed those options. Tests still work fine.<br><br>Change-Id: I3c3f82c7d6aec5fe3acaba1e5dd1d54edba3ba72<br>---<br>M tests/channels/pjsip/transfers/blind_transfer/callee_with_hold/test-config.yaml<br>M tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/test-config.yaml<br>M tests/channels/pjsip/transfers/blind_transfer/caller_with_hold_drop_options/test-config.yaml<br>3 files changed, 18 insertions(+), 18 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/44/9644/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/channels/pjsip/transfers/blind_transfer/callee_with_hold/test-config.yaml b/tests/channels/pjsip/transfers/blind_transfer/callee_with_hold/test-config.yaml</span><br><span>index 92935ca..c007b3d 100644</span><br><span>--- a/tests/channels/pjsip/transfers/blind_transfer/callee_with_hold/test-config.yaml</span><br><span>+++ b/tests/channels/pjsip/transfers/blind_transfer/callee_with_hold/test-config.yaml</span><br><span>@@ -40,25 +40,25 @@</span><br><span> -</span><br><span> scenarios:</span><br><span> # Charlie receives transfered call and sends audio to Alice.</span><br><span style="color: hsl(0, 100%, 40%);">- - { 'key-args': {'scenario': 'charlie.xml', '-p': '5060', '-i': '127.0.0.4', '-timeout': '20s', '-min_rtp_port': '6004', '-max_rtp_port': '6008', '-mi': '127.0.0.4'},</span><br><span style="color: hsl(120, 100%, 40%);">+ - { 'key-args': {'scenario': 'charlie.xml', '-p': '5060', '-i': '127.0.0.4', '-timeout': '20s', '-mi': '127.0.0.4'},</span><br><span> 'ordered-args': ['-timeout_error', '-key', 'custom_media_port', '6004'] }</span><br><span> # Bob receives call from Alice and sends audio. Bob then attempts to blind transfer Alice to Charlie.</span><br><span style="color: hsl(0, 100%, 40%);">- - { 'key-args': {'scenario': 'bob.xml', '-p': '5060', '-i': '127.0.0.3', '-s': 'alice', '-timeout': '20s', '-min_rtp_port': '6004', '-max_rtp_port': '6008', '-mi': '127.0.0.3'},</span><br><span style="color: hsl(120, 100%, 40%);">+ - { 'key-args': {'scenario': 'bob.xml', '-p': '5060', '-i': '127.0.0.3', '-s': 'alice', '-timeout': '20s', '-mi': '127.0.0.3'},</span><br><span> 'ordered-args': ['-timeout_error', '-key', 'custom_media_port', '6004'] }</span><br><span> # Alice calls Bob and sends audio.</span><br><span style="color: hsl(0, 100%, 40%);">- - { 'key-args': {'scenario': 'alice.xml', '-p': '5060', '-i': '127.0.0.2', '-s': 'bob', '-timeout': '20s', '-min_rtp_port': '6004', '-max_rtp_port': '6008', '-mi': '127.0.0.2'},</span><br><span style="color: hsl(120, 100%, 40%);">+ - { 'key-args': {'scenario': 'alice.xml', '-p': '5060', '-i': '127.0.0.2', '-s': 'bob', '-timeout': '20s', '-mi': '127.0.0.2'},</span><br><span> 'ordered-args': ['-timeout_error', '-key', 'custom_media_port', '6004'] }</span><br><span> # Second iteration</span><br><span> -</span><br><span> scenarios:</span><br><span> # Charlie receives transfered call and sends audio to Alice.</span><br><span style="color: hsl(0, 100%, 40%);">- - { 'key-args': {'scenario': 'charlie.xml', '-p': '5060', '-i': '127.0.0.4', '-timeout': '20s', '-min_rtp_port': '6004', '-max_rtp_port': '6008', '-mi': '127.0.0.4'},</span><br><span style="color: hsl(120, 100%, 40%);">+ - { 'key-args': {'scenario': 'charlie.xml', '-p': '5060', '-i': '127.0.0.4', '-timeout': '20s', '-mi': '127.0.0.4'},</span><br><span> 'ordered-args': ['-timeout_error', '-key', 'custom_media_port', '6004'] }</span><br><span> # Bob receives call from Alice and sends audio. Bob then attempts to blind transfer Alice to Charlie.</span><br><span style="color: hsl(0, 100%, 40%);">- - { 'key-args': {'scenario': 'bob.xml', '-p': '5060', '-i': '127.0.0.3', '-s': 'alice', '-timeout': '20s', '-min_rtp_port': '6004', '-max_rtp_port': '6008', '-mi': '127.0.0.3'},</span><br><span style="color: hsl(120, 100%, 40%);">+ - { 'key-args': {'scenario': 'bob.xml', '-p': '5060', '-i': '127.0.0.3', '-s': 'alice', '-timeout': '20s', '-mi': '127.0.0.3'},</span><br><span> 'ordered-args': ['-timeout_error', '-key', 'custom_media_port', '6004'] }</span><br><span> # Alice calls Bob and sends audio.</span><br><span style="color: hsl(0, 100%, 40%);">- - { 'key-args': {'scenario': 'alice.xml', '-p': '5060', '-i': '127.0.0.2', '-s': 'bob_two', '-timeout': '20s', '-min_rtp_port': '6004', '-max_rtp_port': '6008', '-mi': '127.0.0.2'},</span><br><span style="color: hsl(120, 100%, 40%);">+ - { 'key-args': {'scenario': 'alice.xml', '-p': '5060', '-i': '127.0.0.2', '-s': 'bob_two', '-timeout': '20s', '-mi': '127.0.0.2'},</span><br><span> 'ordered-args': ['-timeout_error', '-key', 'custom_media_port', '6004'] }</span><br><span> </span><br><span> ami-config:</span><br><span>diff --git a/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/test-config.yaml b/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/test-config.yaml</span><br><span>index 4b77f4b..26765f5 100644</span><br><span>--- a/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/test-config.yaml</span><br><span>+++ b/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/test-config.yaml</span><br><span>@@ -41,25 +41,25 @@</span><br><span> -</span><br><span> scenarios:</span><br><span> # Charlie receives transfered call and sends audio to Bob.</span><br><span style="color: hsl(0, 100%, 40%);">- - { 'key-args': {'scenario': 'charlie.xml', '-p': '5060', '-i': '127.0.0.4', '-timeout': '20s', '-min_rtp_port': '6004', '-max_rtp_port': '6008', '-mi': '127.0.0.4'},</span><br><span style="color: hsl(120, 100%, 40%);">+ - { 'key-args': {'scenario': 'charlie.xml', '-p': '5060', '-i': '127.0.0.4', '-timeout': '20s', '-mi': '127.0.0.4'},</span><br><span> 'ordered-args': ['-timeout_error', '-key', 'custom_media_port', '6004'] }</span><br><span> # Bob receives call from Alice and sends audio.</span><br><span style="color: hsl(0, 100%, 40%);">- - { 'key-args': {'scenario': 'bob.xml', '-p': '5060', '-i': '127.0.0.3', '-s': 'alice', '-timeout': '20s', '-min_rtp_port': '6004', '-max_rtp_port': '6008', '-mi': '127.0.0.3'},</span><br><span style="color: hsl(120, 100%, 40%);">+ - { 'key-args': {'scenario': 'bob.xml', '-p': '5060', '-i': '127.0.0.3', '-s': 'alice', '-timeout': '20s', '-mi': '127.0.0.3'},</span><br><span> 'ordered-args': ['-timeout_error', '-key', 'custom_media_port', '6004'] }</span><br><span> # Alice calls Bob and sends audio. Alice then attempts to blind transfer Bob to Charlie.</span><br><span style="color: hsl(0, 100%, 40%);">- - { 'key-args': {'scenario': 'alice.xml', '-p': '5060', '-i': '127.0.0.2', '-s': 'bob', '-timeout': '20s', '-min_rtp_port': '6004', '-max_rtp_port': '6008', '-mi': '127.0.0.2'},</span><br><span style="color: hsl(120, 100%, 40%);">+ - { 'key-args': {'scenario': 'alice.xml', '-p': '5060', '-i': '127.0.0.2', '-s': 'bob', '-timeout': '20s', '-mi': '127.0.0.2'},</span><br><span> 'ordered-args': ['-timeout_error', '-key', 'custom_media_port', '6004'] }</span><br><span> # Second iteration</span><br><span> -</span><br><span> scenarios:</span><br><span> # Charlie receives transfered call and sends audio to Bob.</span><br><span style="color: hsl(0, 100%, 40%);">- - { 'key-args': {'scenario': 'charlie.xml', '-p': '5060', '-i': '127.0.0.4', '-timeout': '20s', '-min_rtp_port': '6004', '-max_rtp_port': '6008', '-mi': '127.0.0.4'},</span><br><span style="color: hsl(120, 100%, 40%);">+ - { 'key-args': {'scenario': 'charlie.xml', '-p': '5060', '-i': '127.0.0.4', '-timeout': '20s', '-mi': '127.0.0.4'},</span><br><span> 'ordered-args': ['-timeout_error', '-key', 'custom_media_port', '6004'] }</span><br><span> # Bob receives call from Alice and sends audio.</span><br><span style="color: hsl(0, 100%, 40%);">- - { 'key-args': {'scenario': 'bob.xml', '-p': '5060', '-i': '127.0.0.3', '-s': 'alice', '-timeout': '20s', '-min_rtp_port': '6004', '-max_rtp_port': '6008', '-mi': '127.0.0.3'},</span><br><span style="color: hsl(120, 100%, 40%);">+ - { 'key-args': {'scenario': 'bob.xml', '-p': '5060', '-i': '127.0.0.3', '-s': 'alice', '-timeout': '20s', '-mi': '127.0.0.3'},</span><br><span> 'ordered-args': ['-timeout_error', '-key', 'custom_media_port', '6004'] }</span><br><span> # Alice calls Bob and sends audio. Alice then attempts to blind transfer Bob to Charlie.</span><br><span style="color: hsl(0, 100%, 40%);">- - { 'key-args': {'scenario': 'alice.xml', '-p': '5060', '-i': '127.0.0.2', '-s': 'bob_two', '-timeout': '20s', '-min_rtp_port': '6004', '-max_rtp_port': '6008', '-mi': '127.0.0.2'},</span><br><span style="color: hsl(120, 100%, 40%);">+ - { 'key-args': {'scenario': 'alice.xml', '-p': '5060', '-i': '127.0.0.2', '-s': 'bob_two', '-timeout': '20s', '-mi': '127.0.0.2'},</span><br><span> 'ordered-args': ['-timeout_error', '-key', 'custom_media_port', '6004'] }</span><br><span> </span><br><span> ami-config:</span><br><span>diff --git a/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold_drop_options/test-config.yaml b/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold_drop_options/test-config.yaml</span><br><span>index 23f44a7..4ac14c6 100644</span><br><span>--- a/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold_drop_options/test-config.yaml</span><br><span>+++ b/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold_drop_options/test-config.yaml</span><br><span>@@ -41,25 +41,25 @@</span><br><span> -</span><br><span> scenarios:</span><br><span> # Charlie receives transfered call and sends audio to Bob.</span><br><span style="color: hsl(0, 100%, 40%);">- - { 'key-args': {'scenario': 'charlie.xml', '-p': '5060', '-i': '127.0.0.4', '-timeout': '20s', '-min_rtp_port': '6004', '-max_rtp_port': '6008', '-mi': '127.0.0.4'},</span><br><span style="color: hsl(120, 100%, 40%);">+ - { 'key-args': {'scenario': 'charlie.xml', '-p': '5060', '-i': '127.0.0.4', '-timeout': '20s', '-mi': '127.0.0.4'},</span><br><span> 'ordered-args': ['-timeout_error', '-key', 'custom_media_port', '6004'] }</span><br><span> # Bob receives call from Alice and sends audio.</span><br><span style="color: hsl(0, 100%, 40%);">- - { 'key-args': {'scenario': 'bob.xml', '-p': '5060', '-i': '127.0.0.3', '-s': 'alice', '-timeout': '20s', '-min_rtp_port': '6004', '-max_rtp_port': '6008', '-mi': '127.0.0.3'},</span><br><span style="color: hsl(120, 100%, 40%);">+ - { 'key-args': {'scenario': 'bob.xml', '-p': '5060', '-i': '127.0.0.3', '-s': 'alice', '-timeout': '20s', '-mi': '127.0.0.3'},</span><br><span> 'ordered-args': ['-timeout_error', '-key', 'custom_media_port', '6004'] }</span><br><span> # Alice calls Bob and sends audio. Alice then attempts to blind transfer Bob to Charlie.</span><br><span style="color: hsl(0, 100%, 40%);">- - { 'key-args': {'scenario': 'alice.xml', '-p': '5060', '-i': '127.0.0.2', '-s': 'bob', '-timeout': '20s', '-min_rtp_port': '6004', '-max_rtp_port': '6008', '-mi': '127.0.0.2'},</span><br><span style="color: hsl(120, 100%, 40%);">+ - { 'key-args': {'scenario': 'alice.xml', '-p': '5060', '-i': '127.0.0.2', '-s': 'bob', '-timeout': '20s', '-mi': '127.0.0.2'},</span><br><span> 'ordered-args': ['-timeout_error', '-key', 'custom_media_port', '6004'] }</span><br><span> # Second iteration</span><br><span> -</span><br><span> scenarios:</span><br><span> # Charlie receives transfered call and sends audio to Bob.</span><br><span style="color: hsl(0, 100%, 40%);">- - { 'key-args': {'scenario': 'charlie.xml', '-p': '5060', '-i': '127.0.0.4', '-timeout': '20s', '-min_rtp_port': '6004', '-max_rtp_port': '6008', '-mi': '127.0.0.4'},</span><br><span style="color: hsl(120, 100%, 40%);">+ - { 'key-args': {'scenario': 'charlie.xml', '-p': '5060', '-i': '127.0.0.4', '-timeout': '20s', '-mi': '127.0.0.4'},</span><br><span> 'ordered-args': ['-timeout_error', '-key', 'custom_media_port', '6004'] }</span><br><span> # Bob receives call from Alice and sends audio.</span><br><span style="color: hsl(0, 100%, 40%);">- - { 'key-args': {'scenario': 'bob.xml', '-p': '5060', '-i': '127.0.0.3', '-s': 'alice', '-timeout': '20s', '-min_rtp_port': '6004', '-max_rtp_port': '6008', '-mi': '127.0.0.3'},</span><br><span style="color: hsl(120, 100%, 40%);">+ - { 'key-args': {'scenario': 'bob.xml', '-p': '5060', '-i': '127.0.0.3', '-s': 'alice', '-timeout': '20s', '-mi': '127.0.0.3'},</span><br><span> 'ordered-args': ['-timeout_error', '-key', 'custom_media_port', '6004'] }</span><br><span> # Alice calls Bob and sends audio. Alice then attempts to blind transfer Bob to Charlie.</span><br><span style="color: hsl(0, 100%, 40%);">- - { 'key-args': {'scenario': 'alice.xml', '-p': '5060', '-i': '127.0.0.2', '-s': 'bob_two', '-timeout': '20s', '-min_rtp_port': '6004', '-max_rtp_port': '6008', '-mi': '127.0.0.2'},</span><br><span style="color: hsl(120, 100%, 40%);">+ - { 'key-args': {'scenario': 'alice.xml', '-p': '5060', '-i': '127.0.0.2', '-s': 'bob_two', '-timeout': '20s', '-mi': '127.0.0.2'},</span><br><span> 'ordered-args': ['-timeout_error', '-key', 'custom_media_port', '6004'] }</span><br><span> </span><br><span> ami-config:</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/9644">change 9644</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9644"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I3c3f82c7d6aec5fe3acaba1e5dd1d54edba3ba72 </div>
<div style="display:none"> Gerrit-Change-Number: 9644 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>