<p>George Joseph has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/9507">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">CI: Fix pjsip testsuite tests that are missing type=global<br><br>There are 23 pjsip-related tests that have a "global" section in<br>their pjsip.conf file but don't have a "type=global".  This not only<br>causes the section to be ignored, it also causes the realtime_converter<br>to throw a KeyError because the "type" parameter isn't found.<br><br>Change-Id: I21fddb9d699c937f830ac8ab6084850c0c1aaefe<br>---<br>M tests/channels/pjsip/qualify/call_unreachable/configs/ast1/pjsip.conf<br>M tests/channels/pjsip/rtcp/rtcp_mux_callee/direct/configs/ast1/pjsip.conf<br>M tests/channels/pjsip/rtcp/rtcp_mux_callee/direct/configs/ast2/pjsip.conf<br>M tests/channels/pjsip/rtcp/rtcp_mux_callee/ice/configs/ast1/pjsip.conf<br>M tests/channels/pjsip/rtcp/rtcp_mux_callee/ice/configs/ast2/pjsip.conf<br>M tests/channels/pjsip/rtcp/rtcp_mux_caller/direct/configs/ast1/pjsip.conf<br>M tests/channels/pjsip/rtcp/rtcp_mux_caller/direct/configs/ast2/pjsip.conf<br>M tests/channels/pjsip/rtcp/rtcp_mux_caller/ice/configs/ast1/pjsip.conf<br>M tests/channels/pjsip/rtcp/rtcp_mux_caller/ice/configs/ast2/pjsip.conf<br>M tests/channels/pjsip/rtcp/rtcp_mux_disabled/direct/configs/ast1/pjsip.conf<br>M tests/channels/pjsip/rtcp/rtcp_mux_disabled/direct/configs/ast2/pjsip.conf<br>M tests/channels/pjsip/rtcp/rtcp_mux_disabled/ice/configs/ast1/pjsip.conf<br>M tests/channels/pjsip/rtcp/rtcp_mux_disabled/ice/configs/ast2/pjsip.conf<br>M tests/channels/pjsip/rtcp/rtcp_mux_enabled/direct/configs/ast1/pjsip.conf<br>M tests/channels/pjsip/rtcp/rtcp_mux_enabled/direct/configs/ast2/pjsip.conf<br>M tests/channels/pjsip/rtcp/rtcp_mux_enabled/ice/configs/ast1/pjsip.conf<br>M tests/channels/pjsip/rtcp/rtcp_mux_enabled/ice/configs/ast2/pjsip.conf<br>M tests/hep/rtcp-receiver/configs/ast1/pjsip.conf<br>M tests/hep/rtcp-receiver/configs/ast2/pjsip.conf<br>M tests/hep/rtcp-sender/configs/ast1/pjsip.conf<br>M tests/hep/rtcp-sender/configs/ast2/pjsip.conf<br>M tests/rtp/strict_rtp/configs/ast1/pjsip.conf<br>M tests/rtp/strict_rtp/configs/ast2/pjsip.conf<br>23 files changed, 23 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/07/9507/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/channels/pjsip/qualify/call_unreachable/configs/ast1/pjsip.conf b/tests/channels/pjsip/qualify/call_unreachable/configs/ast1/pjsip.conf</span><br><span>index 0059c9a..e8bdbaf 100644</span><br><span>--- a/tests/channels/pjsip/qualify/call_unreachable/configs/ast1/pjsip.conf</span><br><span>+++ b/tests/channels/pjsip/qualify/call_unreachable/configs/ast1/pjsip.conf</span><br><span>@@ -1,4 +1,5 @@</span><br><span> [global]</span><br><span style="color: hsl(120, 100%, 40%);">+type=global</span><br><span> debug=yes</span><br><span> </span><br><span> [local-transport-udp]</span><br><span>diff --git a/tests/channels/pjsip/rtcp/rtcp_mux_callee/direct/configs/ast1/pjsip.conf b/tests/channels/pjsip/rtcp/rtcp_mux_callee/direct/configs/ast1/pjsip.conf</span><br><span>index 854e9f5..75ad69d 100644</span><br><span>--- a/tests/channels/pjsip/rtcp/rtcp_mux_callee/direct/configs/ast1/pjsip.conf</span><br><span>+++ b/tests/channels/pjsip/rtcp/rtcp_mux_callee/direct/configs/ast1/pjsip.conf</span><br><span>@@ -4,6 +4,7 @@</span><br><span> timer_b=6400</span><br><span> </span><br><span> [global]</span><br><span style="color: hsl(120, 100%, 40%);">+type=global</span><br><span> debug=yes</span><br><span> </span><br><span> [local-transport-udp]</span><br><span>diff --git a/tests/channels/pjsip/rtcp/rtcp_mux_callee/direct/configs/ast2/pjsip.conf b/tests/channels/pjsip/rtcp/rtcp_mux_callee/direct/configs/ast2/pjsip.conf</span><br><span>index fe762d3..7c5f517 100644</span><br><span>--- a/tests/channels/pjsip/rtcp/rtcp_mux_callee/direct/configs/ast2/pjsip.conf</span><br><span>+++ b/tests/channels/pjsip/rtcp/rtcp_mux_callee/direct/configs/ast2/pjsip.conf</span><br><span>@@ -4,6 +4,7 @@</span><br><span> timer_b=6400</span><br><span> </span><br><span> [global]</span><br><span style="color: hsl(120, 100%, 40%);">+type=global</span><br><span> debug=yes</span><br><span> </span><br><span> [local-transport-udp]</span><br><span>diff --git a/tests/channels/pjsip/rtcp/rtcp_mux_callee/ice/configs/ast1/pjsip.conf b/tests/channels/pjsip/rtcp/rtcp_mux_callee/ice/configs/ast1/pjsip.conf</span><br><span>index 6bd5d16..e3813ea 100644</span><br><span>--- a/tests/channels/pjsip/rtcp/rtcp_mux_callee/ice/configs/ast1/pjsip.conf</span><br><span>+++ b/tests/channels/pjsip/rtcp/rtcp_mux_callee/ice/configs/ast1/pjsip.conf</span><br><span>@@ -4,6 +4,7 @@</span><br><span> timer_b=6400</span><br><span> </span><br><span> [global]</span><br><span style="color: hsl(120, 100%, 40%);">+type=global</span><br><span> debug=yes</span><br><span> </span><br><span> [local-transport-udp]</span><br><span>diff --git a/tests/channels/pjsip/rtcp/rtcp_mux_callee/ice/configs/ast2/pjsip.conf b/tests/channels/pjsip/rtcp/rtcp_mux_callee/ice/configs/ast2/pjsip.conf</span><br><span>index 47d66ff..528155b 100644</span><br><span>--- a/tests/channels/pjsip/rtcp/rtcp_mux_callee/ice/configs/ast2/pjsip.conf</span><br><span>+++ b/tests/channels/pjsip/rtcp/rtcp_mux_callee/ice/configs/ast2/pjsip.conf</span><br><span>@@ -4,6 +4,7 @@</span><br><span> timer_b=6400</span><br><span> </span><br><span> [global]</span><br><span style="color: hsl(120, 100%, 40%);">+type=global</span><br><span> debug=yes</span><br><span> </span><br><span> [local-transport-udp]</span><br><span>diff --git a/tests/channels/pjsip/rtcp/rtcp_mux_caller/direct/configs/ast1/pjsip.conf b/tests/channels/pjsip/rtcp/rtcp_mux_caller/direct/configs/ast1/pjsip.conf</span><br><span>index 89f70b3..8e07fba 100644</span><br><span>--- a/tests/channels/pjsip/rtcp/rtcp_mux_caller/direct/configs/ast1/pjsip.conf</span><br><span>+++ b/tests/channels/pjsip/rtcp/rtcp_mux_caller/direct/configs/ast1/pjsip.conf</span><br><span>@@ -4,6 +4,7 @@</span><br><span> timer_b=6400</span><br><span> </span><br><span> [global]</span><br><span style="color: hsl(120, 100%, 40%);">+type=global</span><br><span> debug=yes</span><br><span> </span><br><span> [local-transport-udp]</span><br><span>diff --git a/tests/channels/pjsip/rtcp/rtcp_mux_caller/direct/configs/ast2/pjsip.conf b/tests/channels/pjsip/rtcp/rtcp_mux_caller/direct/configs/ast2/pjsip.conf</span><br><span>index 58ecc7d..4c7185f 100644</span><br><span>--- a/tests/channels/pjsip/rtcp/rtcp_mux_caller/direct/configs/ast2/pjsip.conf</span><br><span>+++ b/tests/channels/pjsip/rtcp/rtcp_mux_caller/direct/configs/ast2/pjsip.conf</span><br><span>@@ -4,6 +4,7 @@</span><br><span> timer_b=6400</span><br><span> </span><br><span> [global]</span><br><span style="color: hsl(120, 100%, 40%);">+type=global</span><br><span> debug=yes</span><br><span> </span><br><span> [local-transport-udp]</span><br><span>diff --git a/tests/channels/pjsip/rtcp/rtcp_mux_caller/ice/configs/ast1/pjsip.conf b/tests/channels/pjsip/rtcp/rtcp_mux_caller/ice/configs/ast1/pjsip.conf</span><br><span>index b74729e..55ff724 100644</span><br><span>--- a/tests/channels/pjsip/rtcp/rtcp_mux_caller/ice/configs/ast1/pjsip.conf</span><br><span>+++ b/tests/channels/pjsip/rtcp/rtcp_mux_caller/ice/configs/ast1/pjsip.conf</span><br><span>@@ -4,6 +4,7 @@</span><br><span> timer_b=6400</span><br><span> </span><br><span> [global]</span><br><span style="color: hsl(120, 100%, 40%);">+type=global</span><br><span> debug=yes</span><br><span> </span><br><span> [local-transport-udp]</span><br><span>diff --git a/tests/channels/pjsip/rtcp/rtcp_mux_caller/ice/configs/ast2/pjsip.conf b/tests/channels/pjsip/rtcp/rtcp_mux_caller/ice/configs/ast2/pjsip.conf</span><br><span>index d3877e0..63d58ed 100644</span><br><span>--- a/tests/channels/pjsip/rtcp/rtcp_mux_caller/ice/configs/ast2/pjsip.conf</span><br><span>+++ b/tests/channels/pjsip/rtcp/rtcp_mux_caller/ice/configs/ast2/pjsip.conf</span><br><span>@@ -4,6 +4,7 @@</span><br><span> timer_b=6400</span><br><span> </span><br><span> [global]</span><br><span style="color: hsl(120, 100%, 40%);">+type=global</span><br><span> debug=yes</span><br><span> </span><br><span> [local-transport-udp]</span><br><span>diff --git a/tests/channels/pjsip/rtcp/rtcp_mux_disabled/direct/configs/ast1/pjsip.conf b/tests/channels/pjsip/rtcp/rtcp_mux_disabled/direct/configs/ast1/pjsip.conf</span><br><span>index 854e9f5..75ad69d 100644</span><br><span>--- a/tests/channels/pjsip/rtcp/rtcp_mux_disabled/direct/configs/ast1/pjsip.conf</span><br><span>+++ b/tests/channels/pjsip/rtcp/rtcp_mux_disabled/direct/configs/ast1/pjsip.conf</span><br><span>@@ -4,6 +4,7 @@</span><br><span> timer_b=6400</span><br><span> </span><br><span> [global]</span><br><span style="color: hsl(120, 100%, 40%);">+type=global</span><br><span> debug=yes</span><br><span> </span><br><span> [local-transport-udp]</span><br><span>diff --git a/tests/channels/pjsip/rtcp/rtcp_mux_disabled/direct/configs/ast2/pjsip.conf b/tests/channels/pjsip/rtcp/rtcp_mux_disabled/direct/configs/ast2/pjsip.conf</span><br><span>index 58ecc7d..4c7185f 100644</span><br><span>--- a/tests/channels/pjsip/rtcp/rtcp_mux_disabled/direct/configs/ast2/pjsip.conf</span><br><span>+++ b/tests/channels/pjsip/rtcp/rtcp_mux_disabled/direct/configs/ast2/pjsip.conf</span><br><span>@@ -4,6 +4,7 @@</span><br><span> timer_b=6400</span><br><span> </span><br><span> [global]</span><br><span style="color: hsl(120, 100%, 40%);">+type=global</span><br><span> debug=yes</span><br><span> </span><br><span> [local-transport-udp]</span><br><span>diff --git a/tests/channels/pjsip/rtcp/rtcp_mux_disabled/ice/configs/ast1/pjsip.conf b/tests/channels/pjsip/rtcp/rtcp_mux_disabled/ice/configs/ast1/pjsip.conf</span><br><span>index 6bd5d16..e3813ea 100644</span><br><span>--- a/tests/channels/pjsip/rtcp/rtcp_mux_disabled/ice/configs/ast1/pjsip.conf</span><br><span>+++ b/tests/channels/pjsip/rtcp/rtcp_mux_disabled/ice/configs/ast1/pjsip.conf</span><br><span>@@ -4,6 +4,7 @@</span><br><span> timer_b=6400</span><br><span> </span><br><span> [global]</span><br><span style="color: hsl(120, 100%, 40%);">+type=global</span><br><span> debug=yes</span><br><span> </span><br><span> [local-transport-udp]</span><br><span>diff --git a/tests/channels/pjsip/rtcp/rtcp_mux_disabled/ice/configs/ast2/pjsip.conf b/tests/channels/pjsip/rtcp/rtcp_mux_disabled/ice/configs/ast2/pjsip.conf</span><br><span>index d3877e0..63d58ed 100644</span><br><span>--- a/tests/channels/pjsip/rtcp/rtcp_mux_disabled/ice/configs/ast2/pjsip.conf</span><br><span>+++ b/tests/channels/pjsip/rtcp/rtcp_mux_disabled/ice/configs/ast2/pjsip.conf</span><br><span>@@ -4,6 +4,7 @@</span><br><span> timer_b=6400</span><br><span> </span><br><span> [global]</span><br><span style="color: hsl(120, 100%, 40%);">+type=global</span><br><span> debug=yes</span><br><span> </span><br><span> [local-transport-udp]</span><br><span>diff --git a/tests/channels/pjsip/rtcp/rtcp_mux_enabled/direct/configs/ast1/pjsip.conf b/tests/channels/pjsip/rtcp/rtcp_mux_enabled/direct/configs/ast1/pjsip.conf</span><br><span>index 89f70b3..8e07fba 100644</span><br><span>--- a/tests/channels/pjsip/rtcp/rtcp_mux_enabled/direct/configs/ast1/pjsip.conf</span><br><span>+++ b/tests/channels/pjsip/rtcp/rtcp_mux_enabled/direct/configs/ast1/pjsip.conf</span><br><span>@@ -4,6 +4,7 @@</span><br><span> timer_b=6400</span><br><span> </span><br><span> [global]</span><br><span style="color: hsl(120, 100%, 40%);">+type=global</span><br><span> debug=yes</span><br><span> </span><br><span> [local-transport-udp]</span><br><span>diff --git a/tests/channels/pjsip/rtcp/rtcp_mux_enabled/direct/configs/ast2/pjsip.conf b/tests/channels/pjsip/rtcp/rtcp_mux_enabled/direct/configs/ast2/pjsip.conf</span><br><span>index fe762d3..7c5f517 100644</span><br><span>--- a/tests/channels/pjsip/rtcp/rtcp_mux_enabled/direct/configs/ast2/pjsip.conf</span><br><span>+++ b/tests/channels/pjsip/rtcp/rtcp_mux_enabled/direct/configs/ast2/pjsip.conf</span><br><span>@@ -4,6 +4,7 @@</span><br><span> timer_b=6400</span><br><span> </span><br><span> [global]</span><br><span style="color: hsl(120, 100%, 40%);">+type=global</span><br><span> debug=yes</span><br><span> </span><br><span> [local-transport-udp]</span><br><span>diff --git a/tests/channels/pjsip/rtcp/rtcp_mux_enabled/ice/configs/ast1/pjsip.conf b/tests/channels/pjsip/rtcp/rtcp_mux_enabled/ice/configs/ast1/pjsip.conf</span><br><span>index b74729e..55ff724 100644</span><br><span>--- a/tests/channels/pjsip/rtcp/rtcp_mux_enabled/ice/configs/ast1/pjsip.conf</span><br><span>+++ b/tests/channels/pjsip/rtcp/rtcp_mux_enabled/ice/configs/ast1/pjsip.conf</span><br><span>@@ -4,6 +4,7 @@</span><br><span> timer_b=6400</span><br><span> </span><br><span> [global]</span><br><span style="color: hsl(120, 100%, 40%);">+type=global</span><br><span> debug=yes</span><br><span> </span><br><span> [local-transport-udp]</span><br><span>diff --git a/tests/channels/pjsip/rtcp/rtcp_mux_enabled/ice/configs/ast2/pjsip.conf b/tests/channels/pjsip/rtcp/rtcp_mux_enabled/ice/configs/ast2/pjsip.conf</span><br><span>index 47d66ff..528155b 100644</span><br><span>--- a/tests/channels/pjsip/rtcp/rtcp_mux_enabled/ice/configs/ast2/pjsip.conf</span><br><span>+++ b/tests/channels/pjsip/rtcp/rtcp_mux_enabled/ice/configs/ast2/pjsip.conf</span><br><span>@@ -4,6 +4,7 @@</span><br><span> timer_b=6400</span><br><span> </span><br><span> [global]</span><br><span style="color: hsl(120, 100%, 40%);">+type=global</span><br><span> debug=yes</span><br><span> </span><br><span> [local-transport-udp]</span><br><span>diff --git a/tests/hep/rtcp-receiver/configs/ast1/pjsip.conf b/tests/hep/rtcp-receiver/configs/ast1/pjsip.conf</span><br><span>index 10b02b0..c66bf2a 100644</span><br><span>--- a/tests/hep/rtcp-receiver/configs/ast1/pjsip.conf</span><br><span>+++ b/tests/hep/rtcp-receiver/configs/ast1/pjsip.conf</span><br><span>@@ -1,4 +1,5 @@</span><br><span> [global]</span><br><span style="color: hsl(120, 100%, 40%);">+type=global</span><br><span> debug=yes</span><br><span> </span><br><span> [local-transport-udp]</span><br><span>diff --git a/tests/hep/rtcp-receiver/configs/ast2/pjsip.conf b/tests/hep/rtcp-receiver/configs/ast2/pjsip.conf</span><br><span>index 2ff0cfb..d8e0bed 100644</span><br><span>--- a/tests/hep/rtcp-receiver/configs/ast2/pjsip.conf</span><br><span>+++ b/tests/hep/rtcp-receiver/configs/ast2/pjsip.conf</span><br><span>@@ -1,4 +1,5 @@</span><br><span> [global]</span><br><span style="color: hsl(120, 100%, 40%);">+type=global</span><br><span> debug=yes</span><br><span> </span><br><span> [local-transport-udp]</span><br><span>diff --git a/tests/hep/rtcp-sender/configs/ast1/pjsip.conf b/tests/hep/rtcp-sender/configs/ast1/pjsip.conf</span><br><span>index 10b02b0..c66bf2a 100644</span><br><span>--- a/tests/hep/rtcp-sender/configs/ast1/pjsip.conf</span><br><span>+++ b/tests/hep/rtcp-sender/configs/ast1/pjsip.conf</span><br><span>@@ -1,4 +1,5 @@</span><br><span> [global]</span><br><span style="color: hsl(120, 100%, 40%);">+type=global</span><br><span> debug=yes</span><br><span> </span><br><span> [local-transport-udp]</span><br><span>diff --git a/tests/hep/rtcp-sender/configs/ast2/pjsip.conf b/tests/hep/rtcp-sender/configs/ast2/pjsip.conf</span><br><span>index 2ff0cfb..d8e0bed 100644</span><br><span>--- a/tests/hep/rtcp-sender/configs/ast2/pjsip.conf</span><br><span>+++ b/tests/hep/rtcp-sender/configs/ast2/pjsip.conf</span><br><span>@@ -1,4 +1,5 @@</span><br><span> [global]</span><br><span style="color: hsl(120, 100%, 40%);">+type=global</span><br><span> debug=yes</span><br><span> </span><br><span> [local-transport-udp]</span><br><span>diff --git a/tests/rtp/strict_rtp/configs/ast1/pjsip.conf b/tests/rtp/strict_rtp/configs/ast1/pjsip.conf</span><br><span>index c633496..21b9693 100644</span><br><span>--- a/tests/rtp/strict_rtp/configs/ast1/pjsip.conf</span><br><span>+++ b/tests/rtp/strict_rtp/configs/ast1/pjsip.conf</span><br><span>@@ -1,4 +1,5 @@</span><br><span> [global]</span><br><span style="color: hsl(120, 100%, 40%);">+type=global</span><br><span> debug=yes</span><br><span> </span><br><span> [local-transport-udp]</span><br><span>diff --git a/tests/rtp/strict_rtp/configs/ast2/pjsip.conf b/tests/rtp/strict_rtp/configs/ast2/pjsip.conf</span><br><span>index 4db6013..32ff3ca 100644</span><br><span>--- a/tests/rtp/strict_rtp/configs/ast2/pjsip.conf</span><br><span>+++ b/tests/rtp/strict_rtp/configs/ast2/pjsip.conf</span><br><span>@@ -1,4 +1,5 @@</span><br><span> [global]</span><br><span style="color: hsl(120, 100%, 40%);">+type=global</span><br><span> debug=yes</span><br><span> </span><br><span> [local-transport-udp]</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/9507">change 9507</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9507"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I21fddb9d699c937f830ac8ab6084850c0c1aaefe </div>
<div style="display:none"> Gerrit-Change-Number: 9507 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>