<p>Nick French has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/9501">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">srtp: lower sdes key lifetime minimum to 2^20<br><br>SRTP SDES key lifetime support was added in ASTERISK-17899.<br><br>In that addition, the minimum key lifetime to be accepted was<br>set at the 10 hours @ 20ms/packet = 1800000 packets.<br><br>The firmware in the obi1xx ATA uses a hardcoded lifetime<br>of 2^20 packets.<br><br>Lower the limit to 2^20 to support a wider field of clients.<br><br>ASTERISK-27967 #close<br><br>Change-Id: Ifa6fe72dd12ddc5a66504f489daa1c7328e989bb<br>---<br>M res/res_srtp.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/01/9501/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/res/res_srtp.c b/res/res_srtp.c</span><br><span>index b92019c..7552a7a 100644</span><br><span>--- a/res/res_srtp.c</span><br><span>+++ b/res/res_srtp.c</span><br><span>@@ -980,8 +980,8 @@</span><br><span>                              sdes_lifetime = n_lifetime;</span><br><span>                  }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-                   /* Accept anything above 10 hours. Less than 10; reject. */</span><br><span style="color: hsl(0, 100%, 40%);">-                     if (sdes_lifetime < 1800000) {</span><br><span style="color: hsl(120, 100%, 40%);">+                     /* Accept anything above ~5.8 hours. Less than ~5.8; reject. */</span><br><span style="color: hsl(120, 100%, 40%);">+                       if (sdes_lifetime < 1048576) {</span><br><span>                            ast_log(LOG_NOTICE, "Rejecting crypto attribute '%s': lifetime '%f' too short\n", attr, sdes_lifetime);</span><br><span>                            continue;</span><br><span>                    }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/9501">change 9501</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9501"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ifa6fe72dd12ddc5a66504f489daa1c7328e989bb </div>
<div style="display:none"> Gerrit-Change-Number: 9501 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nick French <naf@ou.edu> </div>