<p>Joshua Colp <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/9459">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Joshua Colp: Looks good to me, but someone else must approve; Approved for Submit
  George Joseph: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Build: Fix modules getting their optimization setting overridden.<br><br>Asterisk modules that use PJPROJECT services have their compiler<br>optimization and possibly their symbolic debug options overridden by the<br>PJPROJECT configure script selected settings.<br><br>* We need to filter-out any -O and -g options in PJ_CFLAGS before echoing<br>out the result so the PJPROJECT_INCLUDE variable does not override the<br>Asterisk module settings when using bundled PJPROJECT.<br><br>NOTE: This patch only has an effect when using bundled PJPROJECT.<br><br>ASTERISK-27563<br><br>Change-Id: If124169735ecf572ad1535cd43bff94cb44d5b30<br>---<br>M third-party/pjproject/Makefile<br>1 file changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/third-party/pjproject/Makefile b/third-party/pjproject/Makefile</span><br><span>index 6ebd685..dbd2a88 100644</span><br><span>--- a/third-party/pjproject/Makefile</span><br><span>+++ b/third-party/pjproject/Makefile</span><br><span>@@ -155,8 +155,11 @@</span><br><span> </span><br><span> configure: source/build.mak</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+# We need to filter-out any -O and -g options in PJ_CFLAGS before echoing out</span><br><span style="color: hsl(120, 100%, 40%);">+# the result so Asterisk modules don't have the optimization and symbolic debug</span><br><span style="color: hsl(120, 100%, 40%);">+# options overridden by the PJPROJECT configure script selected settings.</span><br><span> echo_cflags: source/build.mak</span><br><span style="color: hsl(0, 100%, 40%);">-   @echo $(PJ_CFLAGS)</span><br><span style="color: hsl(120, 100%, 40%);">+    @echo $(filter-out -O% -g%,$(PJ_CFLAGS))</span><br><span> </span><br><span> libpj%.a: source/build.mak</span><br><span>   $(ECHO_PREFIX) Compiling lib $(@F)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/9459">change 9459</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9459"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: If124169735ecf572ad1535cd43bff94cb44d5b30 </div>
<div style="display:none"> Gerrit-Change-Number: 9459 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>