<p>Robert Mordec <strong>uploaded patch set #4</strong> to this change.</p><p><a href="https://gerrit.asterisk.org/9026">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">app_confbridge: Bridge and announcers not removed if conference ends quickly<br><br>If a conference is ended very quickly after it was created, ie. first user<br>immediatlely hangs up, conference bridge and announcer channels are<br>not removed.<br><br>When conference is created, push_announcer() function is added to playback<br>queue task processor and conference object reference is bumped. If conference<br>is ended while push_announcer() function is still going,<br>ao2_cleanup(conference) at the end of push_announcer() will call<br>the destructor function - destroy_conference_bridge().<br><br>The destroy_conference_bridge() function will then add hangup_playback task<br>to playback queue and will wait for it to end. Since it is already<br>a current task from playback queue it will wait forever.<br><br>This patch lets the conference thread call push_announcer() directly. This way<br>conference object reference bump is not needed. And since playback queue task<br>processor is only used by the conference thread itself, there is no danger<br>of trying to play announcement before the announcer is pushed to the bridge.<br><br>ASTERISK-27870 #close<br><br>Change-Id: I947a50fb121422d90fd1816d643a54d75185a477<br>---<br>M apps/app_confbridge.c<br>1 file changed, 3 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/26/9026/4</pre><p>To view, visit <a href="https://gerrit.asterisk.org/9026">change 9026</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9026"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>
<div style="display:none"> Gerrit-Change-Id: I947a50fb121422d90fd1816d643a54d75185a477 </div>
<div style="display:none"> Gerrit-Change-Number: 9026 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Robert Mordec <r.mordec@slican.pl> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Robert Mordec <r.mordec@slican.pl> </div>