<p>George Joseph <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/9288">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/9288/1/addons/chan_ooh323.c">File addons/chan_ooh323.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9288/1/addons/chan_ooh323.c@3051">Patch Set #1, Line 3051:</a> <code style="font-family:monospace,monospace"> gTOS = 0x02;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">How about creating a define for the 0x02? IPTOS_DEFAULT_MINCOST or something. That way we know what this "magic value" is.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/9288">change 9288</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9288"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Idc9153ece769944765b66122efb11728d8d8ebde </div>
<div style="display:none"> Gerrit-Change-Number: 9288 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Alexander Traud <pabstraud@compuserve.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 26 Jun 2018 13:09:37 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>