<p>Sean Bright <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/9070">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/9070/1/funcs/func_odbc.c">File funcs/func_odbc.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9070/1/funcs/func_odbc.c@862">Patch Set #1, Line 862:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">       if (colcount <= 0) {<br>               ast_verb(4, "Returned %d columns [%s]\n", colcount, ast_str_buffer(sql));<br>           buf[0] = '\0';<br>                ast_copy_string(rowcount, "0", sizeof(rowcount));<br>           status = "NODATA";<br>          SQLCloseCursor(stmt);<br>         SQLFreeHandle (SQL_HANDLE_STMT, stmt);<br>                release_obj_or_dsn (&obj, &dsn);<br>              if (!bogus_chan) {<br>                    pbx_builtin_setvar_helper(chan, "ODBCROWS", rowcount);<br>                      pbx_builtin_setvar_helper(chan, "ODBCSTATUS", status);<br>                      ast_autoservice_stop(chan);<br>           }<br>             odbc_datastore_free(resultset);<br>               return 0;<br>     }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">'rowcount' and 'status' are local variables and we won't use them here unless '!bogus_chan'</p><p style="white-space: pre-wrap; word-wrap: break-word;">Rather than setting them, just use string literals in the calls to pbx_builtin_setvar_helper(), like:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  pbx_builtin_setvar_helper(chan, "ODBCROWS", "0");<br>  pbx_builtin_setvar_helper(chan, "ODBCSTATUS", "NODATA");</pre></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9070/1/funcs/func_odbc.c@1547">Patch Set #1, Line 1547:</a> <code style="font-family:monospace,monospace">                            break;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Are you sure we shouldn't be returning here instead of breaking?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/9070">change 9070</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9070"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ie0f7bdac6c405aa5bbd38932c7b831f90729ee19 </div>
<div style="display:none"> Gerrit-Change-Number: 9070 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 31 May 2018 21:40:40 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>