<p>Joshua Colp <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8932">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8932/1/res/res_hep.c">File res/res_hep.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8932/1/res/res_hep.c@371">Patch Set #1, Line 371:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">static int ast_sockaddr_resolve_first_af(struct ast_sockaddr *addr,<br>                                     const char* name, int flag, int family)<br>{<br>      struct ast_sockaddr *addrs;<br>   int addrs_cnt;<br><br>      addrs_cnt = ast_sockaddr_resolve(&addrs, name, flag, family);<br>     if (addrs_cnt <= 0) {<br>              return 1;<br>     }<br>     if (addrs_cnt > 1) {<br>               ast_debug(1, "Multiple addresses resolving %s, using the first one only\n", name);<br>  }<br><br>   ast_sockaddr_copy(addr, &addrs[0]);<br><br>     ast_free(addrs);<br>      return 0;<br>}<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think this should just go ahead and become a common function, since it's now used in more than one place.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8932">change 8932</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8932"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I33e1a37a8b86e20505dadeda760b861a9ef51f6f </div>
<div style="display:none"> Gerrit-Change-Number: 8932 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matthew Fredrickson <creslin@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 07 May 2018 18:00:17 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>