<p>Matthew Fredrickson <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8637">View Change</a></p><p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(3 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8637/3/channels/chan_dahdi.h">File channels/chan_dahdi.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8637/3/channels/chan_dahdi.h@624">Patch Set #3, Line 624:</a> <code style="font-family:monospace,monospace">        int firstdigit_timeout;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">These should probably be unsigned instead.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8637/3/channels/chan_dahdi.h@629">Patch Set #3, Line 629:</a> <code style="font-family:monospace,monospace">      int interdigit_timeout;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should also probably be unsigned.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8637/3/channels/chan_dahdi.h@634">Patch Set #3, Line 634:</a> <code style="font-family:monospace,monospace">       int matchdigit_timeout;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Unsigned...?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8637">change 8637</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8637"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ib728fa900a4f6ae56d1ed810aba61b6593fb7213 </div>
<div style="display:none"> Gerrit-Change-Number: 8637 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Tzafrir Cohen <tzafrir.cohen@xorcom.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Matthew Fredrickson <creslin@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Oron Peled <oron.peled@xorcom.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 03 May 2018 14:56:38 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>