<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8834">View Change</a></p><p>Patch set 1:</p><p style="white-space: pre-wrap; word-wrap: break-word;">Some minor things</p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8834/1/bridges/bridge_softmix.c">File bridges/bridge_softmix.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8834/1/bridges/bridge_softmix.c@1338">Patch Set #1, Line 1338:</a> <code style="font-family:monospace,monospace">         * still prefers it be accurate instead of lying.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/it be/it to be/</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8834/1/bridges/bridge_softmix.c@2087">Patch Set #1, Line 2087:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">   AST_VECTOR_RESET(&softmix_data->remb_collectors, ao2_cleanup);<br> AST_VECTOR_DEFAULT(&softmix_data->remb_collectors, AST_VECTOR_MAX_SIZE(&softmix_data->remb_collectors), NULL);<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This is kind of inefficient and it changes the number of elements in the vector.  Why not:</p><p style="white-space: pre-wrap; word-wrap: break-word;">int idx;</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">for (idx = 0; idx < AST_VECTOR_SIZE(&softmix_data->remb_collectors); ++idx) {<br>   ao2_cleanup(AST_VECTOR_GET(&softmix_data->remb_collectors, idx));<br>   AST_VECTOR_REPLACE(&softmix_data->remb_collectors, idx, NULL);<br>}</pre></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8834">change 8834</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8834"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ia9dc9c150043890ee7ff85e9cdec007f1a77fcfd </div>
<div style="display:none"> Gerrit-Change-Number: 8834 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 19 Apr 2018 19:29:06 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>