<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8762">View Change</a></p><p>Patch set 4:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(4 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8762/4/main/bridge_channel.c">File main/bridge_channel.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8762/4/main/bridge_channel.c@2376">Patch Set #4, Line 2376:</a> <code style="font-family:monospace,monospace">          ast_sendtext_data(bridge_channel->chan, (struct ast_msg_data *)fr->data.ptr);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Since you have assigned msg to be fr->data.ptr it seems like you should use it here too.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8762/4/main/channel.c">File main/channel.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8762/4/main/channel.c@4897">Patch Set #4, Line 4897:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">              if (body_len == 1) {<br><br>                }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">????</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8762/4/main/channel.c@4923">Patch Set #4, Line 4923:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">              /* Send the body of an enhanced message to a channel driver that supports only a char str */<br>          ast_debug(1, "Sending TEXT to %s: %s\n", ast_channel_name(chan), body);<br>             res = ast_channel_tech(chan)->send_text(chan, body);<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Need the same text/plain check here for legacy.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Passing chan_pjsip w/ any text/xxx content to chan_sip w/ only text/plain support.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8762/4/main/channel.c@4944">Patch Set #4, Line 4944:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                        .value = S_OR((char *)text, ""),<br>            }<br>     };<br><br>  if (ast_strlen_zero(text)) {<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The S_OR() isn't needed anymore with the ast_strlen_zero() exit check restored.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8762">change 8762</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8762"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Idacf5900bfd5f22ab8cd235aa56dfad090d18489 </div>
<div style="display:none"> Gerrit-Change-Number: 8762 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 17 Apr 2018 16:00:47 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>