<p>Joshua Colp <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8773">View Change</a></p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p style="white-space: pre-wrap; word-wrap: break-word;">This should also have an ASTERISK issue created for it.</p><p>(9 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8773/2/res/res_rtp_asterisk.c">File res/res_rtp_asterisk.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8773/2/res/res_rtp_asterisk.c@95">Patch Set #2, Line 95:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><br>#define DEFAULT_RTP_BUFFER_SIZE 100<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think 100 may be too large for now. I think 30 is more reasonable.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8773/2/res/res_rtp_asterisk.c@112">Patch Set #2, Line 112:</a> <code style="font-family:monospace,monospace">#define RTCP_PT_RTPFB AST_RTP_RTCP_RTPFB</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Since it's new code you can go ahead and use AST_RTP_RTCP_RTPFB directly. I used a define previously to reduce the size of the change.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8773/2/res/res_rtp_asterisk.c@519">Patch Set #2, Line 519:</a> <code style="font-family:monospace,monospace">struct ast_rtp_rtcp_nack_payload {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This should also be documented.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8773/2/res/res_rtp_asterisk.c@520">Patch Set #2, Line 520:</a> <code style="font-family:monospace,monospace"> unsigned char buf[0];</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">We normally place zero sized arrays at the end of the structure as the last member.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8773/2/res/res_rtp_asterisk.c@4411">Patch Set #2, Line 4411:</a> <code style="font-family:monospace,monospace"> if (ast_rtp_instance_get_prop(instance, AST_RTP_PROPERTY_RETRANS_SEND) && rtp->send_buffer) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">You don't need to check the prop as well here, just checking for rtp->send_buffer is reasonable.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8773/2/res/res_rtp_asterisk.c@5262">Patch Set #2, Line 5262:</a> <code style="font-family:monospace,monospace"> return res;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">It may be useful to add a debug message here if this scenario occurs.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8773/2/res/res_rtp_asterisk.c@5267">Patch Set #2, Line 5267:</a> <code style="font-family:monospace,monospace"> for (j = 3; j < length; j++) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Document why magic number 3 is used.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8773/2/res/res_rtp_asterisk.c@5274">Patch Set #2, Line 5274:</a> <code style="font-family:monospace,monospace"> }</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">If the payload wasn't found I think it would be useful to have a debug message too.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8773/2/res/res_rtp_asterisk.c@5709">Patch Set #2, Line 5709:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> if (!ast_rtp_instance_get_prop(instance, AST_RTP_PROPERTY_RETRANS_SEND)) {<br> break;<br> }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Would it make sense to also just use rtp->send_buffer here for a check?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8773">change 8773</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8773"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I7f7f124af3b9d5d2fd9cffc6ba8cb48a6fff06ec </div>
<div style="display:none"> Gerrit-Change-Number: 8773 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 16 Apr 2018 11:08:18 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>