<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8764">View Change</a></p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(3 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8764/2/apps/app_sendtext.c">File apps/app_sendtext.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8764/2/apps/app_sendtext.c@54">Patch Set #2, Line 54:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                       <note><para><literal>current channel</literal> could be the caller or callee depending<br>                        on the context in which this application is called.</para></note><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This note still needs to be removed.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8764/2/apps/app_sendtext.c@213">Patch Set #2, Line 213:</a> <code style="font-family:monospace,monospace">            msg_type = "NONE";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Beware of this being a redundant set when fixing the below finding.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8764/2/apps/app_sendtext.c@222">Patch Set #2, Line 222:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">     pbx_builtin_setvar_helper(chan, "SENDTEXTTYPE", msg_type);<br>  pbx_builtin_setvar_helper(chan, "SENDTEXTSTATUS", status);<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">You now have two cleanup code paths that have status, msg_type, or both not set.</p><p style="white-space: pre-wrap; word-wrap: break-word;">You might as well set the initial values on declaration and only change them when needed:</p><p style="white-space: pre-wrap; word-wrap: break-word;">const char *status = "FAILURE";<br>const char *msg_type = "NONE";</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8764">change 8764</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8764"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I648b4574478119f95de09d9f08e9595831b02830 </div>
<div style="display:none"> Gerrit-Change-Number: 8764 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 11 Apr 2018 15:56:24 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>