<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8764">View Change</a></p><p>Patch set 4:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8764/4/apps/app_sendtext.c">File apps/app_sendtext.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8764/4/apps/app_sendtext.c@54">Patch Set #4, Line 54:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                       <note><para><literal>current channel</literal> could be the caller or callee depending<br>                        on the context in which this application is called.</para></note><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This note still needs to be removed.</p><p style="white-space: pre-wrap; word-wrap: break-word;">This note is like saying the sky is blue.  It is true but doesn't tell you anything beyond the obvious.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Also the paragraph above is missing 'the':<br>Sends <replaceable>text</replaceable> to the current channel.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8764/4/apps/app_sendtext.c@201">Patch Set #4, Line 201:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">         msg = ast_msg_data_alloc(AST_MSG_DATA_SOURCE_TYPE_IN_DIALOG, attrs, ARRAY_LEN(attrs));<br>                if (msg) {<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Now the return status string is "UNSUPPORTED" if msg is NULL because of allocation failure.  Should be "FAILURE".</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">status = "FAILURE";<br>if (ast_channel_tech(chan)->send_text_data) {<br>   ...<br>   msg_type = "ENHANCED";<br>   msg = ast_msg_data_alloc();<br>   if (msg) {<br>      if (!ast_sendtext_data()) {<br>          status = "SUCCESS";<br>      }<br>      ast_free(msg);<br>   }<br>} else if (ast_channel_tech(chan)->send_text) {<br>   msg_type = "BASIC";<br>   if (!ast_sendtext()) {<br>      status = "SUCCESS";<br>   }<br>} else {<br>   msg_type = "NONE";<br>   status = "UNSUPPORTED";<br>}</pre></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8764">change 8764</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8764"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I648b4574478119f95de09d9f08e9595831b02830 </div>
<div style="display:none"> Gerrit-Change-Number: 8764 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 11 Apr 2018 17:02:34 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>