<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8580">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(8 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8580/1/main/test.c">File main/test.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8580/1/main/test.c@696">Patch Set #1, Line 696:</a> <code style="font-family:monospace,monospace">static char *complete_test_category(const char *word, int pos)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">pos is not used</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8580/1/main/test.c@756">Patch Set #1, Line 756:</a> <code style="font-family:monospace,monospace">              if (a->pos == 4) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Test should be:<br>if (a->pos == 4 && !strcasecmp(a->argv[3], "category")) {<br>}</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8580/1/main/test.c@763">Patch Set #1, Line 763:</a> <code style="font-family:monospace,monospace">                       return complete_test_name(a->word, a->argv[3]);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Preexisting bug.</p><p style="white-space: pre-wrap; word-wrap: break-word;">The index should be [4] to get the test category instead of getting the literal "category" string.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8580/1/main/test.c@768">Patch Set #1, Line 768:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                        ((a->argc == 4) && strcmp(a->argv[3], "all")) ||<br>                      ((a->argc == 7) && strcmp(a->argv[5], "name"))) {<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should be using strcasecmp()</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8580/1/main/test.c@815">Patch Set #1, Line 815:</a> <code style="font-family:monospace,monospace">                if (a->pos == 3) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Test should be:<br>if (a->pos == 3 && !strcasecmp(a->argv[2], "category")) {<br>}</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8580/1/main/test.c@831">Patch Set #1, Line 831:</a> <code style="font-family:monospace,monospace">               if ((a->argc == 3) && !strcmp(a->argv[2], "all")) { /* run all registered tests */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should be using strcasecmp()</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8580/1/main/test.c@890">Patch Set #1, Line 890:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">              } else if (!strcmp(a->argv[3], "passed")) {<br>                      mode = 2;<br>             } else if (!strcmp(a->argv[3], "failed")) {<br>                      mode = 1;<br>             } else if (!strcmp(a->argv[3], "all")) {<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should be using strcasecmp()</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8580/1/main/test.c@963">Patch Set #1, Line 963:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">               } else if (!strcmp(a->argv[3], "xml")) {<br>                 type = "xml";<br>                       isxml = 1;<br>            } else if (!strcmp(a->argv[3], "txt")) {<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should be using strcasecmp()</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8580">change 8580</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8580"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I5133ff2ba4e030f9733fb3d050c863d72a22ae6b </div>
<div style="display:none"> Gerrit-Change-Number: 8580 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 19 Mar 2018 19:19:04 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>