<p>Corey Farrell <strong>uploaded patch set #2</strong> to this change.</p><p><a href="https://gerrit.asterisk.org/8500">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">core: Remove non-critical cleanup from startup aborts.<br><br>When built-in components of Asterisk fail to start they cause the<br>Asterisk startup to abort. In these cases only the most critical<br>cleanup should be performed - closing databases and terminating<br>proceses. These cleanups are registered using ast_register_atexit, all<br>other cleanups should not be run during startup abort.<br><br>The main reason for this change is that these cleanup procedures are<br>untestable from the partially initialized states, if they fail it could<br>prevent us from ever running the critical cleanup with ast_run_atexits.<br><br>Create separate initialization for dns_core.c to be run unconditionally<br>during startup instead of being initialized by the first dns resolver to<br>be registered. This ensures that 'sched' is initialized before it can be<br>potentially used.<br><br>Replace ast_register_atexit with ast_register_cleanup in media_cache.c.<br>There is no reason for this cleanup to happen unconditionally.<br><br>Change-Id: Iecc2df98008b21509925ff16740bd5fa29527db3<br>---<br>M include/asterisk/_private.h<br>M main/asterisk.c<br>M main/cel.c<br>M main/core_local.c<br>M main/devicestate.c<br>M main/dns_core.c<br>M main/dns_system_resolver.c<br>M main/dsp.c<br>M main/features.c<br>M main/features_config.c<br>M main/indications.c<br>M main/media_cache.c<br>M main/pbx_builtins.c<br>M main/sorcery.c<br>14 files changed, 33 insertions(+), 70 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/00/8500/2</pre><p>To view, visit <a href="https://gerrit.asterisk.org/8500">change 8500</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8500"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>
<div style="display:none"> Gerrit-Change-Id: Iecc2df98008b21509925ff16740bd5fa29527db3 </div>
<div style="display:none"> Gerrit-Change-Number: 8500 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>