<p>sungtae kim <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8166">View Change</a></p><p>Patch set 6:</p><p style="white-space: pre-wrap; word-wrap: break-word;">Hi Corey,</p><p style="white-space: pre-wrap; word-wrap: break-word;">Thank you for your kind review. :) I've fixed what you mentioned.</p><p>(9 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8166/4/main/loader.c">File main/loader.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8166/4/main/loader.c@98">Patch Set #4, Line 98:</a> <code style="font-family:monospace,monospace"> <para>The result of the load request.</para></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">"The result of the load request."</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Fixed it.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8166/4/main/loader.c@104">Patch Set #4, Line 104:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> </parameter><br> </syntax><br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Are these values even possible outside of startup?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Priority: Nope. It sets only when the asterisk is booting.<br>Skip: Nope. It sets only when the asterisk is booting.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I removed those values. :)</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8166/4/main/loader.c@119">Patch Set #4, Line 119:</a> <code style="font-family:monospace,monospace"> </enumlist></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">"The result of the unload request."</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Fixed it.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8166/4/main/loader.c@206">Patch Set #4, Line 206:</a> <code style="font-family:monospace,monospace"> { AST_MODULE_LOAD_DECLINE, "Decline" },</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This field is never read so I think we can drop it.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Right, I just thought it might be useful in the future.<br>But, we can add this whenever it needed. <br>So, I just removed it for now. :)</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8166/4/main/loader.c@1309">Patch Set #4, Line 1309:</a> <code style="font-family:monospace,monospace">/*!</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Let's return "Unknown". In theory this should be unreachable but it will m</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Agree. Fixed it.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8166/4/main/loader.c@1313">Patch Set #4, Line 1313:</a> <code style="font-family:monospace,monospace">static void publish_load_message(const char *name, enum ast_module_load_result result)</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">The "Load" event will not be part of 12 so this is incorrect.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Thanks!</p><p style="white-space: pre-wrap; word-wrap: break-word;">I just removed \since tag, cause I'm not really sure which version of the Asterisk would be patched. But please feel free to let me know or add the tag :)</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8166/4/main/loader.c@1327">Patch Set #4, Line 1327:</a> <code style="font-family:monospace,monospace">{</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Ditto for "Unload" event.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Just the same as above. :)</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8166/4/main/loader.c@1345">Patch Set #4, Line 1345:</a> <code style="font-family:monospace,monospace">{</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">S_OR doesn't modify name, it returns name or "All". I would just pass it d</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Thanks! I've fixed it. :)</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8166/4/main/loader.c@1605">Patch Set #4, Line 1605:</a> <code style="font-family:monospace,monospace">int ast_load_resource(const char *resource_name)</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">We need to replace this return statement with:</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">You're right. I couldn't think about this case. </p><p style="white-space: pre-wrap; word-wrap: break-word;">I've fixed it.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8166">change 8166</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8166"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ib916c41eddd63651952998f2f49c57c42ef87a64 </div>
<div style="display:none"> Gerrit-Change-Number: 8166 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: sungtae kim <pchero21@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: sungtae kim <pchero21@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 12 Feb 2018 22:19:14 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>