<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7960">View Change</a></p><p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(8 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7960/3/res/res_pjsip.c">File res/res_pjsip.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7960/3/res/res_pjsip.c@2421">Patch Set #3, Line 2421:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> <parameter name="ID"><br> <para>The sorcery ID of the contact.</para><br> </parameter><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Delete ID. This is redundant with ObjectName.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7960/3/res/res_pjsip.c@2427">Patch Set #3, Line 2427:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> <enum name="Reachable"/><br> <enum name="Unreachable"/><br> <enum name="NonQualified"/><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The possible enum values are:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">static const char *status_map [] = {<br> [UNAVAILABLE] = "Unreachable",<br> [AVAILABLE] = "Reachable",<br> [UNKNOWN] = "Unknown",<br> [CREATED] = "NonQualified",<br> [REMOVED] = "Removed",<br>};</pre><p style="white-space: pre-wrap; word-wrap: break-word;">Though, "Removed" is not expected to be visible to the user.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7960/3/res/res_pjsip.c@2656">Patch Set #3, Line 2656:</a> <code style="font-family:monospace,monospace"> <para>Provides a listing of all Contacts. For each Contact an <literal>ContactList</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/an/a/</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7960/3/res/res_pjsip.c@2656">Patch Set #3, Line 2656:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><literal>ContactList<br> </literal><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This should be treated as an unbreakable word-wrap string to prevent unexpected spaces from showing up in the literal formatting.</p><p style="white-space: pre-wrap; word-wrap: break-word;">See "manager show command PJSIPShowContacts" output.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7960/3/res/res_pjsip.c@2658">Patch Set #3, Line 2658:</a> <code style="font-family:monospace,monospace"> Once all contacts have been listed an <literal>ContactListComplete</literal> event</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/an/a/</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7960/3/res/res_pjsip/pjsip_options.c">File res/res_pjsip/pjsip_options.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7960/3/res/res_pjsip/pjsip_options.c@967">Patch Set #3, Line 967:</a> <code style="font-family:monospace,monospace"> ast_str_append(&buf, 0, "ID: %s\r\n", ast_sorcery_object_get_id(contact));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Delete the ID header. The ID header value is redundant with the ObjectName header value already output by sip_contact_to_ami().</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7960/3/res/res_pjsip/pjsip_options.c@971">Patch Set #3, Line 971:</a> <code style="font-family:monospace,monospace"> ast_str_append(&buf, 0, "Status: %s\r\n", ast_sip_get_contact_status_label(status ? status->status : UNKNOWN));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Guidelines: wrap long lines at 90 columns</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7960/3/res/res_pjsip/pjsip_options.c@1569">Patch Set #3, Line 1569:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> if (ast_manager_register_xml("PJSIPShowContacts", EVENT_FLAG_SYSTEM, ami_show_contacts)) {<br> return -1;<br> }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Just list</p><p style="white-space: pre-wrap; word-wrap: break-word;">ast_manager_register_xml("PJSIPShowContacts", EVENT_FLAG_SYSTEM, ami_show_contacts);</p><p style="white-space: pre-wrap; word-wrap: break-word;">right after</p><p style="white-space: pre-wrap; word-wrap: break-word;">ast_manager_register_xml("PJSIPQualify", EVENT_FLAG_SYSTEM | EVENT_FLAG_REPORTING, ami_sip_qualify);</p><p style="white-space: pre-wrap; word-wrap: break-word;">If you return you need to clean up allocated resources which you are not doing.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7960">change 7960</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7960"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I2eed42c74bbc725fad26b8b33b1a5b3161950c73 </div>
<div style="display:none"> Gerrit-Change-Number: 7960 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: sungtae kim <pchero21@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: sungtae kim <pchero21@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 23 Jan 2018 00:10:28 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>