<p>Corey Farrell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7872">View Change</a></p><p>Patch set 2:</p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7872/2/res/res_hep_rtcp.c">File res/res_hep_rtcp.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7872/2/res/res_hep_rtcp.c@187">Patch Set #2, Line 187:</a> <code style="font-family:monospace,monospace">  .requires = "res_pjsip",</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Why does this require res_pjsip?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">It actually requires res_hep, this was a mistake.</p><p style="white-space: pre-wrap; word-wrap: break-word;">In addition I missed res_hep_pjsip, the next update will add requires to that module.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7872/2/res/res_pjsip_refer.c">File res/res_pjsip_refer.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7872/2/res/res_pjsip_refer.c@1232">Patch Set #2, Line 1232:</a> <code style="font-family:monospace,monospace"> .requires = "res_pjsip,res_pjsip_session",</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This module currently requires res_pjsip_pubsub (see ASTERISK-27481). Howev</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">ASTERISK-27571 will also change this and many others as res_pjsip_session is going to be removed from master, but I'll add res_pjsip_pubsub now so it's not forgotten.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7872">change 7872</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7872"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I3ad9547a0a6442409ff4e352a6d897bef2cc04bf </div>
<div style="display:none"> Gerrit-Change-Number: 7872 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 11 Jan 2018 21:53:39 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>