<p>Kevin Harwell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6759">View Change</a></p><p>Patch set 1:</p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">It can end up trying to add a better codec in,</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Aren't these the same codecs that were initially offered in the first invite? If the endpoint rejected or pruned them then why send them again?</p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">and the resulting<br>topology is in preference order - so it can, potentially, improve<br>things.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Maybe if the formats were in the same order to being with. But what if the endpoints have the same format list, but in a different order? For instance, endpoint alice = g722, ulaw and bob = ulaw, g722 then bob's preference order get swapped if his topology changes to alice's.</p><ul style="list-style: none; padding-left: 20px;"></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6759">change 6759</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6759"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I8fc0cc03e8bcfd0be8302f13b9f32d8268977f43 </div>
<div style="display:none"> Gerrit-Change-Number: 6759 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 13 Oct 2017 22:09:12 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>