<p>Richard Mudgett has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/6770">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cdr.c: Fix setting dnid, callingsubaddr, and calledsubaddr<br><br>The string comparisons for setting these CDR variables was inverted.  We<br>were repeatedly setting these CDR variables only if the channel snapshots<br>had the same value.<br><br>ASTERISK-27335<br><br>Change-Id: I9482073524411e7ea6c03805b16de200cb1669ea<br>---<br>M main/cdr.c<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/70/6770/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/main/cdr.c b/main/cdr.c<br>index 06cadcd..28dab7e 100644<br>--- a/main/cdr.c<br>+++ b/main/cdr.c<br>@@ -1336,13 +1336,13 @@<br>             set_variable(&old_snapshot->variables, "calledsubaddr", new_snapshot->dialed_subaddr);<br>            return;<br>       }<br>-    if (!strcmp(old_snapshot->snapshot->caller_dnid, new_snapshot->caller_dnid)) {<br>+      if (strcmp(old_snapshot->snapshot->caller_dnid, new_snapshot->caller_dnid)) {<br>                set_variable(&old_snapshot->variables, "dnid", new_snapshot->caller_dnid);<br>        }<br>-    if (!strcmp(old_snapshot->snapshot->caller_subaddr, new_snapshot->caller_subaddr)) {<br>+        if (strcmp(old_snapshot->snapshot->caller_subaddr, new_snapshot->caller_subaddr)) {<br>          set_variable(&old_snapshot->variables, "callingsubaddr", new_snapshot->caller_subaddr);<br>   }<br>-    if (!strcmp(old_snapshot->snapshot->dialed_subaddr, new_snapshot->dialed_subaddr)) {<br>+        if (strcmp(old_snapshot->snapshot->dialed_subaddr, new_snapshot->dialed_subaddr)) {<br>          set_variable(&old_snapshot->variables, "calledsubaddr", new_snapshot->dialed_subaddr);<br>    }<br> }<br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/6770">change 6770</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6770"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 14 </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I9482073524411e7ea6c03805b16de200cb1669ea </div>
<div style="display:none"> Gerrit-Change-Number: 6770 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Mudgett <rmudgett@digium.com> </div>