<p>George Joseph <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6640">View Change</a></p><p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p style="white-space: pre-wrap; word-wrap: break-word;">No 13/14 even without webrtc?</p><p>(4 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/6640/3/configs/samples/pjsip.conf.sample">File configs/samples/pjsip.conf.sample:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6640/3/configs/samples/pjsip.conf.sample@747">Patch Set #3, Line 747:</a> <code style="font-family:monospace,monospace">;dtls_cert_type= ; 'file' or 'ecdsa' depending on the type of certificate</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Mention that if "file" is set and webrtc is also set that we'll automatically fallback to ecdsa if dtls_cert_file isn't set.</p><p style="white-space: pre-wrap; word-wrap: break-word;">What about adding an "auto_fallback" value that means "if dtls_ca_cert is specified, use it, otherwise use ecdsa"? That way the behavior is available even without webrtc. "file" would still be the default to preserve existing behavior.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6640/3/configs/samples/pjsip.conf.sample@795">Patch Set #3, Line 795:</a> <code style="font-family:monospace,monospace">;webrtc= ; When set to "yes" this also enables the following values that are needed</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Mention that if "file" is set and webrtc is also set that we'll automatically fallback to ecdsa if dtls_cert_file isn't set.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/6640/3/include/asterisk/rtp_engine.h">File include/asterisk/rtp_engine.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6640/3/include/asterisk/rtp_engine.h@501">Patch Set #3, Line 501:</a> <code style="font-family:monospace,monospace"> AST_RTP_DTLS_CERTTYPE_ECDSA, /*!< Create ephemeral certificate */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">How about adding AST_RTP_DTLS_CERTTYPE_AUTO_FALLBACK as mentioned in pjsip.conf.sample?</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/6640/3/res/res_pjsip.c">File res/res_pjsip.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6640/3/res/res_pjsip.c@768">Patch Set #3, Line 768:</a> <code style="font-family:monospace,monospace"> <configOption name="dtls_cert_type" default="file"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Mention the webrtc interaction as in pjsip.conf.sample.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6640">change 6640</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6640"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I5122e5f4b83c6320cc17407a187fcf491daf30b4 </div>
<div style="display:none"> Gerrit-Change-Number: 6640 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 10 Oct 2017 11:36:09 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>