<p>Corey Farrell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6618">View Change</a></p><p>Patch set 2:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/6618/2/include/asterisk/logger.h">File include/asterisk/logger.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6618/2/include/asterisk/logger.h@450">Patch Set #2, Line 450:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">         || (ast_opt_dbg_module && ((int)ast_debug_get_by_module(AST_MODULE) >= (level) \<br>           || (int)ast_debug_get_by_module(__FILE__) >= (level))))<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">nit: would you mind tweaking the formatting to make it easier to see that neither call to ast_debug_get_by_module is run unless ast_opt_dbg_module is true?  Maybe each call to ast_debug_get_by_module on a new line with an extra indent?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6618">change 6618</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6618"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Icc0af41837f3b1679dec7af21fa32cd1f7469f6e </div>
<div style="display:none"> Gerrit-Change-Number: 6618 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 28 Sep 2017 17:10:22 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>