<p>Joshua Colp <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6209">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'm not comfortable with this going in as a workaround until we understand the exact flow of things that led you to it. Specifically the device state transitions that occur and when. Is it that internally multiple ringing device updates occur but as one already occurred it does not propagate down to chan_sip? (When it actually can get the ringing channel)? So you let them all through and squash the useless ones when sending the NOTIFY?</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/6209/1/channels/chan_sip.c">File channels/chan_sip.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6209/1/channels/chan_sip.c@15276">Patch Set #1, Line 15276:</a> <code style="font-family:monospace,monospace">                                     break;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Doesn't this result in an invalid dialog-info XML being sent?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6209">change 6209</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6209"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ib31ef1b6dcb9e844b2c1612e634c2a5b88906724 </div>
<div style="display:none"> Gerrit-Change-Number: 6209 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Thierry Magnien <thierry.magnien@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 28 Aug 2017 12:34:27 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>