<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6317">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(3 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/6317/1/main/autoservice.c">File main/autoservice.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6317/1/main/autoservice.c@166">Patch Set #1, Line 166:</a> <code style="font-family:monospace,monospace">                                     defer_frame->subclass.integer == AST_CONTROL_VIDUPDATE) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">It seems we should also track AST_CONTROL_SRCCHANGE and AST_CONTROL_SRCUPDATE for a similar reason.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/6317/1/main/channel.c">File main/channel.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6317/1/main/channel.c@1100">Patch Set #1, Line 1100:</a> <code style="font-family:monospace,monospace">          case AST_CONTROL_VIDUPDATE:</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why is this being blocked?  I'd think that the autoservice change would preclude the need for this change.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/6317/1/main/core_unreal.c">File main/core_unreal.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6317/1/main/core_unreal.c@329">Patch Set #1, Line 329:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> if (f->frametype == AST_FRAME_VOICE) {<br>             if (!ast_channel_get_default_stream(ast, AST_MEDIA_TYPE_AUDIO)) {<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should also drop the AST_CONTROL_SRCUPDATE and AST_CONTROL_SRCCHANGE frames for a similar reason?  Are they audio specific?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6317">change 6317</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6317"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id3f40a6f51b740ae4704003a1800185c0c658ee7 </div>
<div style="display:none"> Gerrit-Change-Number: 6317 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 27 Aug 2017 23:34:04 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>