<p>Kevin Harwell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/5994">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/5994/1/main/core_unreal.c">File main/core_unreal.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5994/1/main/core_unreal.c@326">Patch Set #1, Line 326:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">   /* If we are told to write a frame with a type that has no corresponding<br>       * stream on the channel then drop it.<br>         */<br>   if (f->frametype == AST_FRAME_VOICE) {<br>             if (!ast_channel_get_default_stream(ast, AST_MEDIA_TYPE_AUDIO)) {<br>                     return 0;<br>             }<br>     } else if (f->frametype == AST_FRAME_VIDEO) {<br>              if (!ast_channel_get_default_stream(ast, AST_MEDIA_TYPE_VIDEO)) {<br>                     return 0;<br>             }<br>     }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should this be handled down in the channel write instead of here?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/5994">change 5994</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/5994"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ib7445722c3219951d6740802a0feddf2908c18c8 </div>
<div style="display:none"> Gerrit-Change-Number: 5994 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 12 Jul 2017 15:34:59 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>