[Asterisk-code-review] voicemail.conf: Fix incorrect comment about #include. (asterisk[master])
Sean Bright
asteriskteam at digium.com
Wed Mar 29 09:12:59 CDT 2023
Attention is currently required from: N A.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/20027 )
Change subject: voicemail.conf: Fix incorrect comment about #include.
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File configs/samples/voicemail.conf.sample:
https://gerrit.asterisk.org/c/asterisk/+/20027/comment/855635a0_24a4342b
PS1, Line 7: ; NOTE: Asterisk has to edit this file to change a user's password. This
: ; works with the "#include <file>" directive for Asterisk configuration files,
: ; but not when using realtime static configuration.
: ; If your "source of truth" for voicemail passwords is elsewhere, you should
: ; use the externpassnotify option to keep that synchronized.
If you're confirmed that both voicemail.conf and files #include'd by voicemail.conf can be correctly written by Asterisk, just remove any mention of #includes at all:
```
; NOTE: Asterisk has to edit this file to change a user's password. This does
; not currently work with realtime static configuration. Do not use it with
; this configuration file.
```
I don't know what you are trying to say in the last sentence, but I would be pushing `passwordlocation = spooldir` instead of externpassnotify. If you want to keep this in for some reason, put a blank line in front of it.
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/20027
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I3bf7d275849ab83f55f7fb6702a75a3077ee1df3
Gerrit-Change-Number: 20027
Gerrit-PatchSet: 1
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Wed, 29 Mar 2023 14:12:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230329/309ac716/attachment.html>
More information about the asterisk-code-review
mailing list