[Asterisk-code-review] res_mixmonitor: MixMonitorMute by MixMonitor ID (asterisk[18])

[Sean Bright]

Attention is currently required from: Michael Bradeen, Joshua Colp, N A.

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19969 )

Change subject: res_mixmonitor: MixMonitorMute by MixMonitor ID
......................................................................


Patch Set 4: Code-Review+1

(2 comments)

File apps/app_mixmonitor.c:

https://gerrit.asterisk.org/c/asterisk/+/19969/comment/c31b248b_85a938ab 
PS3, Line 1559: stasis_message_blob = ast_json_pack("{s: s, s: b, s: s, s: i}",
              : 		"direction", direction,
              : 		"state", ast_true(state),
              : 		"mixmonitorid", mixmonitor_id,
              : 		"count", mutedcount);
> It's not actually exposed externally, strictly internally.
Ack


File doc/CHANGES-staging/app_mixmonitor_mute_by_id.txt:

https://gerrit.asterisk.org/c/asterisk/+/19969/comment/4f8a62c5_bda06eb9 
PS3, Line 15: As part of this change, if no MixMonitorID is specified in
> CHANGES updated, previous behavior was semi-undefined depending on if the list of audiohooks is cons […]
Ack



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19969
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ibba8c7e750577aa1595a24b23316ef445245be98
Gerrit-Change-Number: 19969
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Wed, 15 Mar 2023 16:57:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Michael Bradeen <mbradeen at sangoma.com>
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230315/f62817e8/attachment.html>