[Asterisk-code-review] res_mixmonitor: MixMonitorMute by MixMonitor ID (asterisk[18])

[Michael Bradeen]

Attention is currently required from: N A, Joshua Colp.

Michael Bradeen has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19969 )

Change subject: res_mixmonitor: MixMonitorMute by MixMonitor ID
......................................................................


Patch Set 4:

(4 comments)

File apps/app_mixmonitor.c:

https://gerrit.asterisk.org/c/asterisk/+/19969/comment/ac65024b_31f70023 
PS2, Line 1544: {
> spaces needed before/after <
Done


https://gerrit.asterisk.org/c/asterisk/+/19969/comment/b5511a2f_19ef9825 
PS2, Line 1549: 	
> else should be on the same line as the closing brace
Done


File doc/CHANGES-staging/app_mixmonitor_mute_by_id.txt:

https://gerrit.asterisk.org/c/asterisk/+/19969/comment/f6478372_d80c74c0 
PS3, Line 15: As part of this change, if no MixMonitorID is specified in
> This is a behavior change. […]
CHANGES updated, previous behavior was semi-undefined depending on if the list of audiohooks is consistently generated.

The way I read it, previously you would use the id or not, it didn't make sense to sometimes use it. Mute not having it was the outlier and I would consider the current behavior a 'bug'.

If you only use one MixMonitor and never specify an ID, the behavior should be the same in practice.


https://gerrit.asterisk.org/c/asterisk/+/19969/comment/26765eb2_c5b078d4 
PS3, Line 19: ast_audiohook_set_mute_all.
> As well, CHANGES entries are for users, not developers. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19969
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ibba8c7e750577aa1595a24b23316ef445245be98
Gerrit-Change-Number: 19969
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 14 Mar 2023 21:09:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230314/0c0d5903/attachment.html>