[Asterisk-code-review] install_prereq: Refactoring and enhancements. (asterisk[master])

[Martin McCarthy]

Attention is currently required from: Mark Murawski.

Martin McCarthy has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19939 )

Change subject: install_prereq: Refactoring and enhancements.
......................................................................


Patch Set 2:

(11 comments)

Patchset:

PS2: 
Applied fixes as per the code review from K.


File contrib/scripts/install_prereq:

https://gerrit.asterisk.org/c/asterisk/+/19939/comment/e12feadf_47f71740 
PS2, Line 7: installing
> Ack
Fix for 80 column terminals. ✅ 2023-03-06 19:29:54


https://gerrit.asterisk.org/c/asterisk/+/19939/comment/f322e966_7605e238 
PS2, Line 9: # - DragonFly
> Ack
Alphabetically sort this list ✅ 2023-03-06 18:55:12


https://gerrit.asterisk.org/c/asterisk/+/19939/comment/dd7dbd33_d3e73ea2 
PS2, Line 25: # Function name: handle_debian
> Ack
Apologies. This is my styley. I have removed them now.

Remove unnecessary 'x'.  Straight string comparison is sufficient here. ✅ 2023-03-06 18:56:14


https://gerrit.asterisk.org/c/asterisk/+/19939/comment/64acf430_99dcb060 
PS2, Line 26: # Date: 01/11/22
> Ack
I don't think it's necessary to date every function here.  This is not a library/api file.  Same goes for all the others. ✅ 2023-03-06 19:02:49


https://gerrit.asterisk.org/c/asterisk/+/19939/comment/396ce2da_21541717 
PS2, Line 30:     if ! [ -x "$(command -v aptitude)" ] ; then
> Ack
All indenting needs to be tabs ✅ 2023-03-06 18:57:53


https://gerrit.asterisk.org/c/asterisk/+/19939/comment/b4307ab9_d695d9dc 
PS2, Line 41:  
> Ack
Remove unnecessary 'x'.  Straight string comparison is sufficient here. ✅ 2023-03-06 18:56:14


https://gerrit.asterisk.org/c/asterisk/+/19939/comment/9d7d5e35_7dfd8496 
PS2, Line 48:     # We're done!
> Ack
Don't need to write a 'done' comment for every return unless there's something special going on. ✅ 2023-03-06 19:03:49


https://gerrit.asterisk.org/c/asterisk/+/19939/comment/8c15a094_0a1fd369 
PS2, Line 60:     if [ x"$extra_packs" != "x" ] ; then
> Ack
Remove unnecessary 'x'.  Straight string comparison is sufficient here. ✅ 2023-03-06 18:56:14


https://gerrit.asterisk.org/c/asterisk/+/19939/comment/5837f102_5de90a4b 
PS2, Line 79:     if [ x"$extra_packs" != "x" ] ; then
> Ack
Remove unnecessary 'x'.  Straight string comparison is sufficient here. ✅ 2023-03-06 18:56:14


https://gerrit.asterisk.org/c/asterisk/+/19939/comment/a15b8401_466cef72 
PS2, Line 303:         
> Ack
Fix coding style; if [ condition ]; then;   dostuff; fi ✅ 2023-03-06 19:09:30



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19939
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4bd53ae429e113a76d13a23b48da714a8eefad26
Gerrit-Change-Number: 19939
Gerrit-PatchSet: 2
Gerrit-Owner: Martin McCarthy <martin.c.mccarthy at outlook.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Mark Murawski <markm at intellasoft.net>
Gerrit-Attention: Mark Murawski <markm at intellasoft.net>
Gerrit-Comment-Date: Mon, 06 Mar 2023 19:30:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mark Murawski <markm at intellasoft.net>
Comment-In-Reply-To: Martin McCarthy <martin.c.mccarthy at outlook.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230306/d606c601/attachment.html>