[Asterisk-code-review] bridge_builtin_features: add beep via touch variable (asterisk[18])

[Sean Bright]

Attention is currently required from: Michael Bradeen, N A.

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19934 )

Change subject: bridge_builtin_features: add beep via touch variable
......................................................................


Patch Set 2: Code-Review-1

(7 comments)

File bridges/bridge_builtin_features.c:

https://gerrit.asterisk.org/c/asterisk/+/19934/comment/1fa330f7_3cd4008e 
PS2, Line 351: 	char *touch_filename, *mix_options;
`char *touch_filename, mix_options[32] = "b";`


https://gerrit.asterisk.org/c/asterisk/+/19934/comment/c43c5aa9_1070567f 
PS2, Line 413: 		len = strlen(touch_monitor_beep) + 8;
Delete


https://gerrit.asterisk.org/c/asterisk/+/19934/comment/bc500357_2add9c72 
PS2, Line 418: 		mix_options = ast_alloca(len);
Delete


https://gerrit.asterisk.org/c/asterisk/+/19934/comment/40bcdcd5_36444fbc 
PS2, Line 419: 		snprintf(mix_options, len, "bB(%d)", interval);
`snprintf(mix_options, sizeof(mix_options), "bB(%d)", interval);`


https://gerrit.asterisk.org/c/asterisk/+/19934/comment/dfe9da28_404cc5a9 
PS2, Line 421: else {
             : 		mix_options = ast_strdupa("b");
             : 	}
This else branch can be deleted entirely once all of the above is done.


File main/features_config.c:

https://gerrit.asterisk.org/c/asterisk/+/19934/comment/11e1232a_60efda0c 
PS2, Line 202: 						<para>To Play a periodic beep while this call is being recorded, set the
`s/Play/play/`


https://gerrit.asterisk.org/c/asterisk/+/19934/comment/b18abcd5_5aec3ddd 
PS2, Line 221: 						<para>To Play a periodic beep while this call is being recorded, set the
`s/Play/play/`



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19934
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I800e494a789ba7a930bbdcd717e89d86040d6661
Gerrit-Change-Number: 19934
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Thu, 02 Mar 2023 15:23:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230302/3ca07324/attachment-0001.html>