[Asterisk-code-review] res_pjsip: Replace invalid UTF-8 sequences in callerid name (asterisk[18])

[George Joseph]

Attention is currently required from: Sean Bright, Joshua Colp.

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19898 )

Change subject: res_pjsip: Replace invalid UTF-8 sequences in callerid name
......................................................................


Patch Set 10:

(5 comments)

File include/asterisk/utf8.h:

https://gerrit.asterisk.org/c/asterisk/+/19898/comment/a1213929_27578b5d 
PS10, Line 125: 	AST_UTF8_FAIL,
> This is never used anywhere.
Done


File main/utf8.c:

https://gerrit.asterisk.org/c/asterisk/+/19898/comment/36430b29_989b0754 
PS10, Line 115: 	if (!src) {
> This change seems unrelated to the main purpose of this review. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/19898/comment/0b09fb84_6352c612 
PS10, Line 130: 	if (!src) {
> This change seems unrelated to the main purpose of this review. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/19898/comment/e70b059f_373c3e31 
PS10, Line 186: char *repl = "\xef\xbf\xbd";
              : 	size_t repl_len = strlen(repl);
> These could be const static. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/19898/comment/7ae4fdf7_9a79875b 
PS10, Line 910: 
> This blank line bothers me
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19898
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I4ffbdb19c80bf0efc675d40078a3ca4f85c567d8
Gerrit-Change-Number: 19898
Gerrit-PatchSet: 10
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 01 Mar 2023 15:20:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230301/77ab0a2e/attachment-0001.html>