[Asterisk-code-review] chan_iax2: Fix jitterbuffer regression prior to receiving audio. (asterisk[master])

[Jaco Kroon]

Attention is currently required from: N A.

Jaco Kroon has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19712 )

Change subject: chan_iax2: Fix jitterbuffer regression prior to receiving audio.
......................................................................


Patch Set 6:

(2 comments)

File channels/chan_iax2.c:

https://gerrit.asterisk.org/c/asterisk/+/19712/comment/87aaf030_eed3ecdb 
PS6, Line 4171: 			ast_log(LOG_WARNING, "No voice format and no peer format available on %s, skipping frame\n", ast_channel_name(chan));
05:54:42  chan_iax2.c: In function '__get_from_jb':
05:54:42  chan_iax2.c:4171:114: error: 'chan' undeclared (first use in this function)
05:54:42      ast_log(LOG_WARNING, "No voice format and no peer format available on %s, skipping frame\n", ast_channel_name(chan));
05:54:42                                                                                                                    ^
05:54:42  chan_iax2.c:4171:114: note: each undeclared identifier is reported only once for each function it appears in
05:54:42  make[1]: *** [chan_iax2.o] Error 1

__get_from_jb doesn't receive the chan from the caller.  pvt->owner I believe should be the one you're looking for.


https://gerrit.asterisk.org/c/asterisk/+/19712/comment/48f0d22a_aff75e5d 
PS6, Line 4215: cleanup:
OK, so here I have a question:

Won't this cause a blocking until voiceformat does pass, ie, it won't actually jb_get the next frames, as in ever, or at least until voiceformat does get set, and then burst them?  Which is why even without early media one won't get RINGING on the caller side.  In other words, if the peerformat is also not set, the current bug will persist.

I do think there are bigger (configuration problems if this is the case, so not too worried, I think this shall be "good enough").  But in reality we're not actually dropping the frame, we're backlogging it.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19712
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie4fd1e8e088a145ad89e0427c2100a530e964fe9
Gerrit-Change-Number: 19712
Gerrit-PatchSet: 6
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Jaco Kroon <jaco at uls.co.za>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Tue, 31 Jan 2023 12:13:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230131/3a7384a0/attachment.html>