[Asterisk-code-review] chan_iax2: Fix jitterbuffer regression prior to receiving audio. (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, Jaco Kroon.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19712 )

Change subject: chan_iax2: Fix jitterbuffer regression prior to receiving audio.
......................................................................


Patch Set 4:

(3 comments)

Patchset:

PS3: 
> This looks good to me, two minor comments in the code, and a more general overview here. […]
I agree with your comments here, I'm not completely sure about the peerformat vs ast_format_none, I'd definitely appreciate someone else's input on this as well.


PS3: 
> Did you plan on responding to Jaco's comment?
Done


File channels/chan_iax2.c:

https://gerrit.asterisk.org/c/asterisk/+/19712/comment/570d750b_431c1069 
PS2, Line 4169: 	if (voicefmt && ms >= (next = jb_next(pvt->jb))) {
> At this point voicefmt should always be properly set, so no need for the voicefmt check in the if st […]
I've moved the assignments around. I left the second if voicefmt there just in case there wasn't a peerformat for whatever reason, but not sure if that's possible or not.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19712
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie4fd1e8e088a145ad89e0427c2100a530e964fe9
Gerrit-Change-Number: 19712
Gerrit-PatchSet: 4
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Jaco Kroon <jaco at uls.co.za>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Jaco Kroon <jaco at uls.co.za>
Gerrit-Comment-Date: Thu, 26 Jan 2023 13:25:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Jaco Kroon <jaco at uls.co.za>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230126/0c214c71/attachment.html>