[Asterisk-code-review] app_confbridge: Fix bridge shutdown race condition. (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18577 )

Change subject: app_confbridge: Fix bridge shutdown race condition.
......................................................................


Patch Set 4:

(2 comments)

File apps/app_confbridge.c:

https://gerrit.asterisk.org/c/asterisk/+/18577/comment/1ec7e7a1_5099cd5d 
PS1, Line 1906: 	/* Rare, but if threads interleave exactly right, the bridge could disappear
> I think the code at this point is foolproof, because this is the point where we try to enter the bri […]
Ack


File apps/app_confbridge.c:

https://gerrit.asterisk.org/c/asterisk/+/18577/comment/2512388c_1c74da62 
PS3, Line 1803: 		conference = NULL;
> This leaks conference as the reference returned by ao2_find isn't released. […]
Not sure I have a great answer for that now, what would you suggest? First checking if conference is still in the channels container, and if not, deducing it was already removed, and just bailing?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18577
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I08a440eafbf83ec4b502d1e44c3f4d44c4a522f9
Gerrit-Change-Number: 18577
Gerrit-PatchSet: 4
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 28 Feb 2023 14:51:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230228/b9b202e3/attachment.html>