[Asterisk-code-review] app_queue: periodic announcement configurable start time. (asterisk[master])

[Jaco Kroon]

Attention is currently required from: N A, Joshua Colp.

Jaco Kroon has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19899 )

Change subject: app_queue: periodic announcement configurable start time.
......................................................................


Patch Set 4:

(2 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/19899/comment/06bc48f5_02b2ae5e 
PS3, Line 8: time interval than the frequency.
> The commit message title is so long that it wraps to a another line. Can you make it shorter and move the details into the body?
> 
> Also it should begin "Add option", not just "option"

Turns out to be fairly hard given the length of words like periodic and announcement.  Please advise if attempt 4 is more to your liking.


File configs/samples/queues.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/19899/comment/d9a1efa9_6730b769 
PS1, Line 283: ; may not always be desired.
> That part is clear, but I might rephrase "should the periodic announcements start" to "the periodic  […]
Rewrite completely, please do check if the latest attempt is better.  English is not my native tongue so I frequently get the nuances wrong.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19899
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ia79984b6377ef78f167ad9ea2ac084bec29955d0
Gerrit-Change-Number: 19899
Gerrit-PatchSet: 4
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 28 Feb 2023 06:40:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: Jaco Kroon <jaco at uls.co.za>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230228/b9895d28/attachment.html>