[Asterisk-code-review] app_queue: option to start the periodic announcements at a different... (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, Jaco Kroon.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19899 )

Change subject: app_queue:  option to start the periodic announcements at a different time interval than the frequency.
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/19899/comment/dd803628_bd04becc 
PS3, Line 8: time interval than the frequency.
The commit message title is so long that it wraps to a another line. Can you make it shorter and move the details into the body?

Also it should begin "Add option", not just "option"


File configs/samples/queues.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/19899/comment/fadf2d1c_61be9cd3 
PS1, Line 283: ; may not always be desired.
> I figured "normally" implies "if unset". […]
That part is clear, but I might rephrase "should the periodic announcements start" to "the periodic announcements should start", so it sounds more like a statement than a question. Very minor, but just reads a bit easier that way.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19899
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ia79984b6377ef78f167ad9ea2ac084bec29955d0
Gerrit-Change-Number: 19899
Gerrit-PatchSet: 3
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Jaco Kroon <jaco at uls.co.za>
Gerrit-Comment-Date: Fri, 24 Feb 2023 12:40:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: Jaco Kroon <jaco at uls.co.za>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230224/70d4522c/attachment.html>